Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1194010

[PATCH 3.12 094/124] vfs: Remove incorrect debugging WARN in prepend_path

Show all headers | View raw

From: "Eric W. Biederman" <ebiederm@xmission.com>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit 93e3bce6287e1fb3e60d3324ed08555b5bbafa89 upstream.

The warning message in prepend_path is unclear and outdated.  It was
added as a warning that the mechanism for generating names of pseudo
files had been removed from prepend_path and d_dname should be used
instead.  Unfortunately the warning reads like a general warning,
making it unclear what to do with it.

Remove the warning.  The transition it was added to warn about is long
over, and I added code several years ago which in rare cases causes
the warning to fire on legitimate code, and the warning is now firing
and scaring people for no good reason.

Reported-by: Ivan Delalande <colona@arista.com>
Reported-by: Omar Sandoval <osandov@osandov.com>
Fixes: f48cfddc6729e ("vfs: In d_path don't call d_dname on a mount point")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
 fs/dcache.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index e619730ade4c..64cfe24cdd88 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2812,17 +2812,6 @@ restart:
 				vfsmnt = &mnt->mnt;
 				continue;
 			}
-			/*
-			 * Filesystems needing to implement special "root names"
-			 * should do so with ->d_dname()
-			 */
-			if (IS_ROOT(dentry) &&
-			   (dentry->d_name.len != 1 ||
-			    dentry->d_name.name[0] != '/')) {
-				WARN(1, "Root dentry has weird name <%.*s>\n",
-				     (int) dentry->d_name.len,
-				     dentry->d_name.name);
-			}
 			if (!error)
 				error = is_mounted(vfsmnt) ? 1 : 2;
 			break;
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3.12 000/124] 3.12.45-stable review Jiri Slaby <jslaby@suse.cz> - 2015-07-28 11:50 +0200
  [PATCH 3.12 094/124] vfs: Remove incorrect debugging WARN in prepend_path Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 106/124] cpuidle / menu: Return (-1) if there are no suitable states Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 108/124] regmap: Fix possible shift overflow in regmap_field_init() Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 103/124] arm64: Do not attempt to use init_mm in reset_context() Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 107/124] regmap: Fix regmap_bulk_read in BE mode Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 115/124] thermal: rcar: fix ENR register value Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 100/124] ALSA: hda - Add headset support to Acer Aspire V5 Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 102/124] ARC: add compiler barrier to LLSC based cmpxchg Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
    [PATCH 3.12 096/124] x86/PCI: Use host bridge _CRS info on systems with >32 bit addressing Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:10 +0200
  [PATCH 3.12 001/124] iio: adc: twl6030-gpadc: Fix modalias Jiri Slaby <jslaby@suse.cz> - 2015-07-28 12:40 +0200
  Re: [PATCH 3.12 000/124] 3.12.45-stable review Jiri Slaby <jslaby@suse.cz> - 2015-08-03 10:10 +0200

csiph-web