Groups > linux.kernel > #1193794

Re: [RFC][PATCH 5/7] jump_label: Rework update logic

From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 5/7] jump_label: Rework update logic
Date	2015-07-28 08:00 +0200
Message-ID	<pR65I-d2-7@gated-at.bofh.it> (permalink)
References	<pPPzX-4Yj-5@gated-at.bofh.it> <pPPzY-4Yj-25@gated-at.bofh.it> <pQO8O-7zV-7@gated-at.bofh.it> <pQTBw-7n7-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 27, 2015 at 06:30:05PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 27, 2015 at 12:47:14PM +0200, Peter Zijlstra wrote:
> > @@ -68,13 +63,8 @@ void static_key_slow_inc(struct static_k
> >  		return;
> >  
> >  	jump_label_lock();
> > +	if (atomic_inc_and_test(&key->enabled))
> 
> atomic_inc_return() == 1, works _much_ better.

Confirmed. With this change, the jump_label_init() patch, plus the
changes in s390 inline asm everything works for me.

There are a couple of places in s390 code where the DEFINE_STATIC_KEY_FALSE
and static_branch_likely() combination would make sense.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 5/7] jump_label: Rework update logic Peter Zijlstra <peterz@infradead.org> - 2015-07-27 12:50 +0200
  Re: [RFC][PATCH 5/7] jump_label: Rework update logic Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-07-28 08:00 +0200

csiph-web