Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1193673
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources |
| Date | 2015-07-28 02:50 +0200 |
| Message-ID | <pR1fI-1AI-17@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <pP60b-6bF-27@gated-at.bofh.it> <pQQX2-3uw-33@gated-at.bofh.it> <pQRq3-4iB-63@gated-at.bofh.it> <pQRJo-4Ft-23@gated-at.bofh.it> <pQS2K-52h-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jul 27, 2015 at 02:50:15PM +0000, Shenwei Wang wrote:
> The following structure is currently used in both drivers. The members "gpc_base/
> wakeup_sources/enabled_irqs" are now shared to PM driver. And the macro IMR_NUM
> will be referred by both drivers too.
>
> struct imx_gpcv2_irq {
> spinlock_t lock;
> void __iomem *gpc_base;
So this is the virtual base used by both irqchip and pm driver, and the
lock is for register access protection, right? If so, we can define gpc
as a syscon device, and access it from both drivers with regmap.
> u32 wakeup_sources[IMR_NUM];
This should be an irqchip internal data and exported to external users like
pm code with an interface like imx_gpcv2_get_wakeup_sources().
> u32 enabled_irqs[IMR_NUM];
I do not see how this is used in pm driver.
> u32 cpu2wakeup;
The only use of this in pm driver is to unmask interrupt #32 during
initialization. Why cannot it be done in irqchip driver initialization?
Shawn
> };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shenwei Wang <shenwei.wang@freescale.com> - 2015-07-22 19:30 +0200
Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shawn Guo <shawnguo@kernel.org> - 2015-07-27 15:50 +0200
RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shenwei Wang <Shenwei.Wang@freescale.com> - 2015-07-27 16:20 +0200
Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shawn Guo <shawnguo@kernel.org> - 2015-07-27 16:40 +0200
RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shenwei Wang <Shenwei.Wang@freescale.com> - 2015-07-27 17:00 +0200
Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shawn Guo <shawnguo@kernel.org> - 2015-07-28 02:50 +0200
RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Shenwei Wang <Shenwei.Wang@freescale.com> - 2015-07-27 16:00 +0200
csiph-web