Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1193665

Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow

Show all headers | View raw

On 28.07.2015 06:24, Javier Martinez Canillas wrote:
> Hello Michal,
> 
> The patch looks good to me, just one small comment below.
> 
> On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek <hramrach@gmail.com> wrote:
>> Although there is only one choice of chipselect it is necessary to
>> specify it. The driver cannot claim the gpio otherwise.
>>
>> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
>>
>> --
>> v2
>>  - don't move unrelated line
>> ---
>>  arch/arm/boot/dts/exynos5250-snow.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index b7f4122..62be08a 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -688,6 +688,7 @@
>>         status = "okay";
>>         samsung,spi-src-clk = <0>;
>>         num-cs = <1>;
>> +       cs-gpios = <&gpa2 5 0>;
> 
> NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or
> Krzysztof can fixup when applying it?
> 
>>  };
>>
>>  &usbdrd_dwc3 {
>> --
> 
> Acked-by: Javier Martinez Canillas <javier@osg.samsung.com>

Yes, the GPIO_ACTIVE_HIGH would be better. Can you re-spin the patch
with this change and respective Acks? Including mine ack:
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow Javier Martinez Canillas <javier@dowhile0.org> - 2015-07-27 23:30 +0200
  Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-28 02:40 +0200

csiph-web