Groups > linux.kernel > #1192422

Re: [PATCH 4/3] x86/ldt: allow to disable modify_ldt at runtime

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Willy Tarreau <w@1wt.eu>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/3] x86/ldt: allow to disable modify_ldt at runtime
Date	Sat, 25 Jul 2015 20:50:01 +0200
Message-ID	<pQcGd-4py-13@gated-at.bofh.it> (permalink)
References	<pQ0lH-3FD-3@gated-at.bofh.it> <pQ0lH-3FD-1@gated-at.bofh.it> <pQ185-4Pc-5@gated-at.bofh.it> <pQ1rr-5bo-3@gated-at.bofh.it> <pQ2xc-6Hb-17@gated-at.bofh.it> <pQ7nd-5oa-29@gated-at.bofh.it> <pQabn-YF-5@gated-at.bofh.it> <pQaEp-1xN-15@gated-at.bofh.it> <pQbK9-34C-5@gated-at.bofh.it>
X-Original-To	Andy Lutomirski <luto@amacapital.net>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.4.2.3i
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>, "security@kernel.org" <security@kernel.org>, X86 ML <x86@kernel.org>, Borislav Petkov <bp@alien8.de>, Sasha Levin <sasha.levin@oracle.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>, Kees Cook <keescook@chromium.org>
X-Original-Date	Sat, 25 Jul 2015 20:45:45 +0200
X-Original-Message-ID	<20150725184545.GB17740@1wt.eu>
X-Original-References	<cover.1437802102.git.luto@kernel.org> <7286d77aa81abc38dc40362e2439861427064f6f.1437802102.git.luto@kernel.org> <20150725062343.GA3902@1wt.eu> <CALCETrX0ExTFXVdNthwBRheg4vsffPThVuyn7uAcj_TGwpXgiA@mail.gmail.com> <20150725075052.GA3918@1wt.eu> <20150725130340.GA17257@1wt.eu> <CALCETrV+OB0qxtw5CHaZc5RftuCUax04RxTyi_bt4ZKDJ2GB0g@mail.gmail.com> <20150725163356.GD17659@1wt.eu> <CALCETrXeWdugPpAkKhUD=f7ftuYSM5fxaPxnF2=PwygupP2_4w@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1192422

Show key headers only | View raw

On Sat, Jul 25, 2015 at 10:42:14AM -0700, Andy Lutomirski wrote:
> On Sat, Jul 25, 2015 at 9:33 AM, Willy Tarreau <w@1wt.eu> wrote:
> > On Sat, Jul 25, 2015 at 09:08:39AM -0700, Andy Lutomirski wrote:
> >> There's one thing that I think is incomplete here.  Currently, espfix
> >> triggers if SS points to the LDT.  It's possible for SS to point to
> >> the LDT even with modify_ldt disabled, and there's a decent amount of
> >> attack surface there.
> >>
> >> Can we improve this?  Two ideas:
> >>
> >> 1. In the asm, patch out or otherwise disable espfix if that sysctl
> >> has never been set.  (Ick.)
> >>
> >> 2. When modify_ldt is runtime-disabled (or compile-time disabled,
> >> perhaps), disallow setting the LDT bit in SS in the handful of places
> >> that would allow it (ptrace and sigreturn off the top of my head).  We
> >> don't need to worry about (regs->ss & 4) being set on kernel entry
> >> because we'll never be in user mode with that bit set if the LDT is
> >> disabled, but that bit could still be set using kernel APIs.  (In
> >> fact, my sigreturn test does exactly that.)
> >>
> >> Hmm.  With synchronous LDT, we could plausibly check at runtime in the
> >> espfix code, too.  We used to use LAR to do this, but hpa removed it
> >> when he realized that it was racy.  It shouldn't be racy any more,
> >> because, with my patches applied, the LDT never changes while
> >> interrupts are off.
> >
> > I understand it's not complete but I'm a bit bothered with conflating
> > this sysctl with other setting methods, because if the purpose of the
> > sysctl is to disable the syscall, it should do that only. I'd rather
> > document that it's less complete than the Kconfig method and continue
> > to recommend using your option whenever possible (eg: all my kernels
> > will use it just as I've already disabled X86_16BIT everywhere).
> >
> 
> Agreed.  We can certainly tighten up the espfix code later.
> 
> > Also one benefit of having both options is that it will mechanically
> > make LDT a much less interesting target for future attacks, since it
> > will significantly reduce the likeliness of success, hence the motivation
> > for writing exploits that only work in conferences.
> >
> 
> Patch looks fine to me.

OK thanks.

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/3] x86/ldt: allow to disable modify_ldt at runtime Andy Lutomirski <luto@amacapital.net> - 2015-07-25 18:10 +0200
  Re: [PATCH 4/3] x86/ldt: allow to disable modify_ldt at runtime Willy Tarreau <w@1wt.eu> - 2015-07-25 18:40 +0200
    Re: [PATCH 4/3] x86/ldt: allow to disable modify_ldt at runtime Andy Lutomirski <luto@amacapital.net> - 2015-07-25 19:50 +0200
      Re: [PATCH 4/3] x86/ldt: allow to disable modify_ldt at runtime Willy Tarreau <w@1wt.eu> - 2015-07-25 20:50 +0200

csiph-web