Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1192412

Re: [PATCH] mtd: gpio-addr-flash: add missing iounmap in probe/remove

Show all headers | View raw

Hi Alexey,

On 25 July 2015 at 13:49, Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:
> There is no iounmap(state->map.virt) in gpio_flash_remove() and
> in gpio_flash_probe() error handling code.
>

Is there any reason why we can't just use managed variants? E.g.

diff --git a/drivers/mtd/maps/gpio-addr-flash.c
b/drivers/mtd/maps/gpio-addr-flash.c
index 2fb3460..bbaa92b 100644
--- a/drivers/mtd/maps/gpio-addr-flash.c
+++ b/drivers/mtd/maps/gpio-addr-flash.c
@@ -238,7 +238,8 @@ static int gpio_flash_probe(struct platform_device *pdev)
        state->map.copy_to    = gf_copy_to;
        state->map.bankwidth  = pdata->width;
        state->map.size       = state->win_size * (1 << state->gpio_count);
-       state->map.virt       = ioremap_nocache(memory->start, state->map.size);
+       state->map.virt       = devm_ioremap_nocache(&pdev->dev, memory->start,
+                                                    state->map.size);
        state->map.phys       = NO_XIP;
        state->map.map_priv_1 = (unsigned long)state;

Notice the error checks are still needed though, but managed stuff would make
it simpler.

-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: gpio-addr-flash: add missing iounmap in probe/remove Alexey Khoroshilov <khoroshilov@ispras.ru> - 2015-07-25 19:00 +0200
  Re: [PATCH] mtd: gpio-addr-flash: add missing iounmap in probe/remove Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-07-25 19:50 +0200

csiph-web