Groups > linux.kernel > #1192959

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface
Date	2015-07-27 13:00 +0200
Message-ID	<pQOiu-7Lc-3@gated-at.bofh.it> (permalink)
References	<pPPzX-4Yj-5@gated-at.bofh.it> <pPPzY-4Yj-21@gated-at.bofh.it> <pQO8O-7zV-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 27, 2015 at 12:45:10PM +0200, Peter Zijlstra wrote:
> --- a/arch/s390/include/asm/jump_label.h
> +++ b/arch/s390/include/asm/jump_label.h
> +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch)
> +{
> +	asm_volatile_goto("0:	brcl 15, %l[l_yes]\n"
> +		".pushsection __jump_table, \"aw\"\n"
> +		".balign 8\n"
> +		".quad 0b, %l[label], %0\n"
> +		".popsection\n"
> +		: : "X" (&((char *)key)[branch]) : : label);

The above should have been

	asm_volatile_goto("0:	brcl 15,%l[label]\n"

(label instead of l_yes). Just recognized this, sorry..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra <peterz@infradead.org> - 2015-07-27 12:50 +0200
  Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-07-27 13:00 +0200

csiph-web