Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1192875
| From | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Xen-devel] [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages |
| Date | 2015-07-27 11:40 +0200 |
| Message-ID | <pQN34-62M-13@gated-at.bofh.it> (permalink) |
| References | <pPJEd-4HJ-5@gated-at.bofh.it> <pPK7h-5uX-25@gated-at.bofh.it> <pPUzE-3HY-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 25/07/15 00:21, Julien Grall wrote:
> On 24/07/2015 12:47, David Vrabel wrote:
>> @@ -550,6 +551,11 @@ int alloc_xenballooned_pages(int nr_pages, struct
>> page **pages)
>> page = balloon_retrieve(true);
>> if (page) {
>> pages[pgno++] = page;
>> +#ifdef CONFIG_XEN_HAVE_PVMMU
>> + ret = xen_alloc_p2m_entry(page_to_pfn(page));
>
> Don't you want to call this function only when the guest is not using
> auto-translated physmap?
xen_alloc_p2m_entry() is a nop in auto-xlate guests, so no need for an
additional check here.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCHv2 00/10] mm, xen/balloon: memory hotplug improvements David Vrabel <david.vrabel@citrix.com> - 2015-07-24 13:50 +0200
[PATCHv2 07/10] xen/balloon: make alloc_xenballoon_pages() always allocate low pages David Vrabel <david.vrabel@citrix.com> - 2015-07-24 13:50 +0200
[PATCHv2 09/10] x86/xen: export xen_alloc_p2m_entry() David Vrabel <david.vrabel@citrix.com> - 2015-07-24 14:00 +0200
[PATCHv2 04/10] xen/balloon: find non-conflicting regions to place hotplugged memory David Vrabel <david.vrabel@citrix.com> - 2015-07-24 14:00 +0200
[PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages David Vrabel <david.vrabel@citrix.com> - 2015-07-24 14:20 +0200
Re: [Xen-devel] [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages David Vrabel <david.vrabel@citrix.com> - 2015-07-27 11:40 +0200
csiph-web