Groups > linux.kernel > #1192652

Re: [PATCH v10 7/7] sched: Clean up load average references

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 7/7] sched: Clean up load average references
Date	Mon, 27 Jul 2015 06:30:01 +0200
Message-ID	<pQId3-7Ap-9@gated-at.bofh.it> (permalink)
References	<pMpLH-18z-3@gated-at.bofh.it> <pMpLH-18z-5@gated-at.bofh.it> <pPOky-30M-27@gated-at.bofh.it>
X-Original-To	Dietmar Eggemann <dietmar.eggemann@arm.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.15,550,1432623600"; d="scan'208";a="771634911"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	"mingo@kernel.org" <mingo@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "pjt@google.com" <pjt@google.com>, "bsegall@google.com" <bsegall@google.com>, Morten Rasmussen <Morten.Rasmussen@arm.com>, "vincent.guittot@linaro.org" <vincent.guittot@linaro.org>, "umgwanakikbuti@gmail.com" <umgwanakikbuti@gmail.com>, "len.brown@intel.com" <len.brown@intel.com>, "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>, "arjan@linux.intel.com" <arjan@linux.intel.com>, "fengguang.wu@intel.com" <fengguang.wu@intel.com>
X-Original-Date	Mon, 27 Jul 2015 04:31:22 +0800
X-Original-Message-ID	<20150726203122.GG28512@intel.com>
X-Original-References	<1436918682-4971-1-git-send-email-yuyang.du@intel.com> <1436918682-4971-8-git-send-email-yuyang.du@intel.com> <55B26AC9.5040508@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1192652

Show key headers only | View raw

Hi Dietmar,

On Fri, Jul 24, 2015 at 05:41:45PM +0100, Dietmar Eggemann wrote:
> On 15/07/15 01:04, Yuyang Du wrote:
> > For cfs_rq, we have load.weight, runnable_load_avg, and load_avg. We
> > now start to clean up how they are used.
> > 
> > First, as group sched_entity already largely uses load_avg, we now expand
> > to use load_avg in all cases.
> 
> You're talking about group se's or cfs_rq owned by the group se's
> (se->my_q) here or both?
 
Definitely, group SE, and if the cfs_rq owned by group SE is also concerned
with group SE, then both. I don't think this is very well calculated to be 
optimal, but probably this is the right move I can think of now.

We need to revisit all of the codes before we can at least make a final call.

> Just asking because both data structures (cfs_rq and se) have a 'struct
> load_weight load' as well as 'struct sched_avg avg' member.
> 
>  Second, for CPU-wide load balancing, we
> > choose to use runnable_load_avg in all cases, which is the same as before
> > this series.
> 
> With your patch-set there will be still the difference of
> 'cfs_rq->utilization_load_avg' and your 'cfs_rq->avg.util_avg' in the
> sense that the former one does not contain the contribution of blocked se's.
> 
> The EAS patch-set adds blocked utilization contribution:
> https://lkml.org/lkml/2015/7/7/915
> 
> The cfs_rq utilization is also used by the load-balancer code via
> get_cpu_usage() so the blocked utilization contribution to
> 'cfs_rq->avg.util_avg' can change load-balancing as well.
> 
> Since it is not as heavily used as the cfs_rq->runnable_load_avg we
> might not need to reintroduce cfs_rq->utilization_load_avg but at least
> mention this here.
> 

Yes, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v10 7/7] sched: Clean up load average references Yuyang Du <yuyang.du@intel.com> - 2015-07-27 06:30 +0200

csiph-web