Groups > linux.kernel > #1192653

Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq
Date	Mon, 27 Jul 2015 06:30:01 +0200
Message-ID	<pQId3-7Ap-11@gated-at.bofh.it> (permalink)
References	<pMpLH-18z-3@gated-at.bofh.it> <pMpLI-18z-11@gated-at.bofh.it> <pOued-1sr-1@gated-at.bofh.it> <pOBfJ-32u-37@gated-at.bofh.it> <pOCOt-5nc-11@gated-at.bofh.it> <pOD7Q-5JB-25@gated-at.bofh.it> <pQGuB-54l-1@gated-at.bofh.it> <pQHgZ-6dy-1@gated-at.bofh.it> <pQHAl-6zT-1@gated-at.bofh.it> <pQHTI-7bD-11@gated-at.bofh.it>
X-Original-To	Boqun Feng <boqun.feng@gmail.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.15,550,1432623600"; d="scan'208";a="771635559"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, pjt@google.com, bsegall@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, umgwanakikbuti@gmail.com, len.brown@intel.com, rafael.j.wysocki@intel.com, arjan@linux.intel.com, fengguang.wu@intel.com
X-Original-Date	Mon, 27 Jul 2015 04:34:09 +0800
X-Original-Message-ID	<20150726203409.GH28512@intel.com>
X-Original-References	<1436918682-4971-1-git-send-email-yuyang.du@intel.com> <1436918682-4971-7-git-send-email-yuyang.du@intel.com> <20150721010346.GA2882@fixme-laptop.cn.ibm.com> <20150721004400.GA28512@intel.com> <20150721101845.GB2882@fixme-laptop.cn.ibm.com> <20150721102956.GA5380@fixme-laptop.cn.ibm.com> <20150726184325.GB28512@intel.com> <20150727032114.GA3328@fixme-laptop.cn.ibm.com> <20150726195634.GE28512@intel.com> <20150727040420.GC3328@fixme-laptop.cn.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1192653

Show key headers only | View raw

On Mon, Jul 27, 2015 at 12:04:20PM +0800, Boqun Feng wrote:
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > 1) blocked load is more "difficult" to track, hint, migrate.
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
> 
> I may not get your point here? Are you saying my patch fails to handle
> the migration or are you just telling me that blocked load tracking need
> to take migration into consideration?

Both, is it so difficult to get?
 
> If it's the latter one, I want to say that, with blocked load or not, we
> have to handle load_avg in migrations, so *adding* some code to handle
> blocked load is not a big deal.
> 
> Please consider this piece of code in update_cfs_rq_load_avg(), which
> decays and updates blocked_load_avg.
 
At this point of time, you tell me why exactly you want to track the blocked?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Boqun Feng <boqun.feng@gmail.com> - 2015-07-27 05:30 +0200
  Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Boqun Feng <boqun.feng@gmail.com> - 2015-07-27 05:40 +0200
  Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Yuyang Du <yuyang.du@intel.com> - 2015-07-27 05:50 +0200
    Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Boqun Feng <boqun.feng@gmail.com> - 2015-07-27 06:10 +0200
      Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Yuyang Du <yuyang.du@intel.com> - 2015-07-27 06:30 +0200

csiph-web