Groups > linux.kernel > #1192639

Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq

From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq
Date	2015-07-27 05:40 +0200
Message-ID	<pQHqG-6oE-9@gated-at.bofh.it> (permalink)
References	<pMpLH-18z-3@gated-at.bofh.it> <pMpLI-18z-11@gated-at.bofh.it> <pORXb-1Mj-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 22, 2015 at 10:19:54AM +0800, Boqun Feng wrote:
> 
> > +/* Remove the runnable load generated by se from cfs_rq's runnable load average */
> > +static inline void
> > +dequeue_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se)
> > +{
> > +	update_load_avg(se, 1);
> > +
> 
> I think we need an update_cfs_rq_load_avg() here? Because the
> runnable_load_avg may not be up to date when dequeue_entity_load_avg()
> is called, right?

Not in update_load_avg()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v10 6/7] sched: Provide runnable_load_avg back to cfs_rq Yuyang Du <yuyang.du@intel.com> - 2015-07-27 05:40 +0200

csiph-web