Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1192586

Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds

Show all headers | View raw

From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
Date: Fri, 24 Jul 2015 15:49:39 +0000

>> -----Original Message-----
>> From: Joe Perches [mailto:joe@perches.com]
>> On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
>> > Allow the user to tweak the refill threshold and the total number
>> > of buffers in the buffer pool. The provided values are for one CPU.
>> 
>> Any value in making these module parameters instead?
> 
> I expect one would (hardly ever) change these to improve some corner
> cases then use them with the new values. It may help in the tuning process
> but afterwards the bloat to the bootcmd would probably be  a nuisance.

I think these should be controlled by the existing ethtool infrastructure.

Neither the Kconfig mechanism nor module parameters are appropriate, at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/10] devres: add devm_alloc_percpu() Madalin Bucur <madalin.bucur@freescale.com> - 2015-07-22 19:00 +0200
  Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet Joe Perches <joe@perches.com> - 2015-07-22 19:40 +0200
  Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds Joe Perches <joe@perches.com> - 2015-07-22 19:50 +0200
    Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds David Miller <davem@davemloft.net> - 2015-07-27 01:40 +0200
  Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet Joakim Tjernlund <joakim.tjernlund@transmode.se> - 2015-07-29 16:20 +0200

csiph-web