Groups > linux.kernel > #1191351

Re: [PATCH 1/5] Add blank line under variable declaration.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] Add blank line under variable declaration.
Date	2015-07-24 00:00 +0200
Message-ID	<pPwH1-2zU-45@gated-at.bofh.it> (permalink)
References	<pPpFw-RC-25@gated-at.bofh.it> <pPpFw-RC-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

For all of these, you need a better subject line that shows what part of
the kernel you are modifying.

For example, this one would be:
	Subject: [PATCH 1/5] staging: lustre: cl_page.c: add blank line after variable definition

On Thu, Jul 23, 2015 at 02:21:10PM +0800, Incarnation P. Lee wrote:
> Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>
> 

We need a changelog entry, it can't be blank.

And I need a hint of "real" name here, is "Incarnation P. Lee" how you
sign legal documents?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] Add blank line under variable declaration. Greg KH <gregkh@linuxfoundation.org> - 2015-07-24 00:00 +0200

csiph-web