Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1191212
| From | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge |
| Date | 2015-07-23 20:40 +0200 |
| Message-ID | <pPtzr-6sr-9@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <pPqLg-2oy-11@gated-at.bofh.it> <pPr4C-2Lu-15@gated-at.bofh.it> <pPrei-3cd-27@gated-at.bofh.it> <pPstJ-4VP-31@gated-at.bofh.it> <pPt6q-5Um-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 23, 2015 at 11:01 AM, Andy Lutomirski <luto@amacapital.net> wrote: > On Thu, Jul 23, 2015 at 10:27 AM, Brian Gerst <brgerst@gmail.com> wrote: >> On Thu, Jul 23, 2015 at 12:02 PM, Andy Lutomirski <luto@amacapital.net> wrote: >>> On Thu, Jul 23, 2015 at 8:56 AM, Steven Rostedt <rostedt@goodmis.org> wrote: >>>> On Thu, 23 Jul 2015 08:31:39 -0700 >>>> Andy Lutomirski <luto@kernel.org> wrote: >>>> >>>>> Switch from wrmsr to wrmsrl_safe to prepare to merge the 32-bit and >>>>> 64-bit code, and use __KERNEL_CS explicitly to initialize >>>>> MSR_IA32_SYSENTER_CS. While we're at it, tweak the whitespace a >>>>> bit. >>>> >>>> Saying "prepare to merge the 32-bit and 64-bit" isn't that informative >>>> to why this patch is needed. Can you please describe in the change log >>>> what can fault with the wrmsr call, when we do the merge? >>> >>> Oh... >>> >>> Nothing can fault in the wrmsr as far as I know, but maybe there's a >>> CPU out there that advertises SEP but doesn't have the MSRs. >>> >>> Ingo, Thomas, want a v2 that explains that the wrmsr_safe is there for >>> consistency but that I don't know why 32bit does it? Another option >>> would be to remove the _safe from the 32-bit version. >> >> There is an erratum with SEP being advertised but not available on >> early P6 models, but we already check for that in the cpu setup code. >> There shouldn't be a problem with a fault. > > I can make a v2 that gets rid of the _safe. > Ugh. wrmsrl_safe is a function but wrmsrl isn't. I'll fix that and send a v2. Gah, macros. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge Brian Gerst <brgerst@gmail.com> - 2015-07-23 19:30 +0200
Re: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge Andy Lutomirski <luto@amacapital.net> - 2015-07-23 20:10 +0200
Re: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge Andy Lutomirski <luto@amacapital.net> - 2015-07-23 20:40 +0200
Re: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge Andy Lutomirski <luto@amacapital.net> - 2015-07-23 20:50 +0200
Re: [PATCH 1/5] x86/entry/32: Clean up enable_sep_cpu to prepare for 64-bit merge Linus Torvalds <torvalds@linux-foundation.org> - 2015-07-23 21:00 +0200
csiph-web