Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1191208

Re: [PATCH] MIPS: Remove most of the custom gpio.h

Show all headers | View raw

On 07/22/2015 07:33 PM, Alban Bedel wrote:
> diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c
> index 54c80d4..3dc500c 100644
> --- a/arch/mips/jz4740/gpio.c
> +++ b/arch/mips/jz4740/gpio.c
> @@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask)
>   }
>   EXPORT_SYMBOL(jz_gpio_port_get_value);
>
> -int gpio_to_irq(unsigned gpio)
> -{
> -	return JZ4740_IRQ_GPIO(0) + gpio;
> -}
> -EXPORT_SYMBOL_GPL(gpio_to_irq);

This need to be hooked up the gpio_to_irq() callback of the gpio_chip struct 
of this driver rather than completely removing it. Otherwise this 
functionality will be broken.

Similar for other platforms which implement the function.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS: Remove most of the custom gpio.h Alban Bedel <albeu@free.fr> - 2015-07-22 19:40 +0200
  Re: [PATCH] MIPS: Remove most of the custom gpio.h Manuel Lauss <manuel.lauss@gmail.com> - 2015-07-22 19:50 +0200
  Re: [PATCH] MIPS: Remove most of the custom gpio.h Linus Walleij <linus.walleij@linaro.org> - 2015-07-23 15:10 +0200
  Re: [PATCH] MIPS: Remove most of the custom gpio.h Lars-Peter Clausen <lars@metafoo.de> - 2015-07-23 20:30 +0200
    Re: [PATCH] MIPS: Remove most of the custom gpio.h Linus Walleij <linus.walleij@linaro.org> - 2015-07-27 15:30 +0200

csiph-web