Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1191148
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: question about drivers/dma/dma-jz4780.c |
| Date | 2015-07-23 19:20 +0200 |
| Message-ID | <pPsk2-4Kr-25@gated-at.bofh.it> (permalink) |
| References | <pNSLE-6F3-9@gated-at.bofh.it> <pOesO-3Zl-25@gated-at.bofh.it> <pOeCu-4aD-21@gated-at.bofh.it> <pOxc5-5J3-5@gated-at.bofh.it> <pP3bX-YT-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jul 22, 2015 at 03:26:01PM +0100, Alex Smith wrote: > >>>I think the explicit devm_free_irq() here is unnecessary, as when remove is > >>>called there should be no remaining users of the DMA controller and therefore > >>>no chance of an IRQ occurring between the controller being unregistered and an > >>>implicit IRQ release afterwards. > >Are you ensuring that device can no longer sent interrupts and all instances > >of tasklet running or either completed are terminated and no further tasklet > >can be spawned? > > Hi Vinod, > > If I understand correctly, when remove() is called, there should be > no more users of the DMA controller, enforced by the module > reference count. > > Wouldn't that guarantee that there are no more transactions running > and therefore no chance of an interrupt from the controller or a > tasklet still running? That will only guarantee no new requests are recieved, but you may have tasklet already scheduled or irq sent from HW how do you prevent that? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: question about drivers/dma/dma-jz4780.c Alex Smith <alex.smith@imgtec.com> - 2015-07-22 16:30 +0200
Re: question about drivers/dma/dma-jz4780.c Vinod Koul <vinod.koul@intel.com> - 2015-07-23 19:20 +0200
Re: question about drivers/dma/dma-jz4780.c Julia Lawall <julia.lawall@lip6.fr> - 2015-07-23 19:30 +0200
Re: question about drivers/dma/dma-jz4780.c Alex Smith <alex.smith@imgtec.com> - 2015-07-24 10:30 +0200
csiph-web