Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1190882

RE: [v3, 5/9] fsl/fman: Add Frame Manager support

Show all headers | View raw

Regards,
Igal Liberman.

> +static struct platform_driver fm_driver = {
> +	.driver = {
> +		   .name = "fsl-fman",
> +		   .of_match_table = fm_match,
> +		   },
> +	.probe = fm_probe,
> +};
> +
> +builtin_platform_driver(fm_driver);
> +
> +static int __init __cold fm_load(void)
> +{
> +	if (platform_driver_register(&fm_driver)) {
> +		pr_crit("platform_driver_register() failed\n");
> +		return -ENODEV;
> +	}
> +
> +	pr_info("Freescale FMan module\n");
> +	return 0;
> +}
> +
> +device_initcall(fm_load);

Please notice, when using builtin_platform_driver, device_initcall(fm_load); becomes redundant. 
Same issue in 2 other places.
I have patches which fix that which were left out of this submission, I'll add them to v4.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [v3, 5/9] fsl/fman: Add Frame Manager support Liberman Igal <Igal.Liberman@freescale.com> - 2015-07-23 14:50 +0200

csiph-web