Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1190660

Re: [PATCH v5 7/7] powerpc/powernv: nest pmu cpumask and cpu hotplug support

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 7/7] powerpc/powernv: nest pmu cpumask and cpu hotplug support
Date Thu, 23 Jul 2015 08:50:02 +0200
Message-ID <pPium-7ld-13@gated-at.bofh.it> (permalink)
References <pMPmO-50R-3@gated-at.bofh.it> <pMPmO-50R-7@gated-at.bofh.it> <pOUs1-5s1-1@gated-at.bofh.it>
X-Original-To Daniel Axtens <dja@axtens.net>
X-Helo d23dlp03.au.ibm.com
X-Mailfrom maddy@linux.vnet.ibm.com
X-Rcptto linux-kernel@vger.kernel.org
User-Agent Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Transfer-Encoding 7bit
X-Tm-As-Mml disable
X-Content-Scanned Fidelis XPS MAILER
X-Cbid 15072306-0009-0000-0000-000001C281FB
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Cc linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Stephane Eranian <eranian@google.com>, Paul Mackerras <paulus@samba.org>, Anton Blanchard <anton@samba.org>, Preeti U Murthy <preetium@andrew.cmu.edu>, Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>, Ingo Molnar <mingo@kernel.org>, Anshuman Khandual <khandual@linux.vnet.ibm.com>
X-Original-Date Thu, 23 Jul 2015 12:18:08 +0530
X-Original-Message-ID <55B08E28.3090902@linux.vnet.ibm.com>
X-Original-References <1437045206-7491-1-git-send-email-maddy@linux.vnet.ibm.com> <1437045206-7491-8-git-send-email-maddy@linux.vnet.ibm.com> <1437541404.30906.43.camel@axtens.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1190660

Show key headers only | View raw



On Wednesday 22 July 2015 10:33 AM, Daniel Axtens wrote:
>> +static void nest_change_cpu_context(int old_cpu, int new_cpu)
>> +{
>> +	int i;
>> +
>> +	for (i = 0; per_nest_pmu_arr[i] != NULL; i++)
>> +		perf_pmu_migrate_context(&per_nest_pmu_arr[i]->pmu,
>> +						old_cpu, new_cpu);
> From patch 4, I see per_nest_pmu_arr is defined as:
>  +static struct nest_pmu *per_nest_pmu_arr[P8_NEST_MAX_PMUS];
>
> Therefore, does this loop need to have a check that 
> i < P8_NEST_MAX_PMUS?

No, that is max possible pmu, but we may have only couple for nest pmus
registered.

Thanks for the review comments
Maddy
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v5 7/7] powerpc/powernv: nest pmu cpumask and cpu hotplug  support Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-07-23 08:50 +0200
  Re: [PATCH v5 7/7] powerpc/powernv: nest pmu cpumask and cpu  hotplug support Daniel Axtens <dja@axtens.net> - 2015-07-23 09:00 +0200
    Re: [PATCH v5 7/7] powerpc/powernv: nest pmu cpumask and cpu hotplug  support Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-07-23 09:30 +0200

csiph-web