Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1190627

[PATCH] mm, page_isolation: make set/unset_migratetype_isolate() file-local

Show all headers | View raw

Nowaday, set/unset_migratetype_isolate() is defined and used only in
mm/page_isolation, so let's limit the scope within the file.

Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
---
 include/linux/page-isolation.h | 5 -----
 mm/page_isolation.c            | 5 +++--
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git v4.2-rc2.orig/include/linux/page-isolation.h v4.2-rc2/include/linux/page-isolation.h
index 2dc1e1697b45..047d64706f2a 100644
--- v4.2-rc2.orig/include/linux/page-isolation.h
+++ v4.2-rc2/include/linux/page-isolation.h
@@ -65,11 +65,6 @@ undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
 int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
 			bool skip_hwpoisoned_pages);
 
-/*
- * Internal functions. Changes pageblock's migrate type.
- */
-int set_migratetype_isolate(struct page *page, bool skip_hwpoisoned_pages);
-void unset_migratetype_isolate(struct page *page, unsigned migratetype);
 struct page *alloc_migrate_target(struct page *page, unsigned long private,
 				int **resultp);
 
diff --git v4.2-rc2.orig/mm/page_isolation.c v4.2-rc2/mm/page_isolation.c
index 32fdc1df05e5..4568fd58f70a 100644
--- v4.2-rc2.orig/mm/page_isolation.c
+++ v4.2-rc2/mm/page_isolation.c
@@ -9,7 +9,8 @@
 #include <linux/hugetlb.h>
 #include "internal.h"
 
-int set_migratetype_isolate(struct page *page, bool skip_hwpoisoned_pages)
+static int set_migratetype_isolate(struct page *page,
+				bool skip_hwpoisoned_pages)
 {
 	struct zone *zone;
 	unsigned long flags, pfn;
@@ -72,7 +73,7 @@ int set_migratetype_isolate(struct page *page, bool skip_hwpoisoned_pages)
 	return ret;
 }
 
-void unset_migratetype_isolate(struct page *page, unsigned migratetype)
+static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
 {
 	struct zone *zone;
 	unsigned long flags, nr_pages;
-- 
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm, page_isolation: make set/unset_migratetype_isolate()  file-local Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-07-23 07:50 +0200
  Re: [PATCH] mm, page_isolation: make set/unset_migratetype_isolate()  file-local Vlastimil Babka <vbabka@suse.cz> - 2015-07-23 20:40 +0200

csiph-web