Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1190351

Re: [PATCH v4 00/10] hugetlbfs: add fallocate support

Show all headers | View raw

On 07/22/2015 03:30 PM, Andrew Morton wrote:
> On Wed, 22 Jul 2015 15:19:54 -0700 Davidlohr Bueso <dave@stgolabs.net> wrote:
>
>>>
>>> I didn't know that libhugetlbfs has tests.  I wonder if that makes
>>> tools/testing/selftests/vm's hugetlbfstest harmful?
>>
>> Why harmful? Redundant, maybe(?).
>
> The presence of the in-kernel tests will cause people to add stuff to
> them when it would be better if they were to apply that effort to
> making libhugetlbfs better.  Or vice versa.
>
> Mike's work is an example.  Someone later makes a change to hugetlbfs, runs
> the kernel selftest and says "yay, everything works", unaware that they
> just broke fallocate support.
>
>> Does anyone even use selftests for
>> hugetlbfs regression testing? Lets see, we also have these:
>>
>> - hugepage-{mmap,shm}.c
>> - map_hugetlb.c
>>
>> There's probably a lot of room for improvement here.
>
> selftests is a pretty scrappy place.  It's partly a dumping ground for
> things so useful test code doesn't just get lost and bitrotted.  Partly
> a framework so people who add features can easily test them. Partly to
> provide tools to architecture maintainers when they wire up new
> syscalls and the like.
>
> Unless there's some good reason to retain the hugetlb part of
> selftests, I'm thinking we should just remove it to avoid
> distracting/misleading people.  Or possibly move the libhugetlbfs test
> code into the kernel tree and maintain it there.

Adding Eric as he is the libhugetlbfs maintainer.

I think removing the hugetlb selftests in the kernel and pointing
people to libhugetlbfs is the way to go.  From a very quick scan
of the selftests, I would guess libhugetlbfs covers everything
in those tests.

I'm willing to verify the testing provided by selftests is included
in libhugetlbfs, and remove selftests if that is the direction we
want to take.

-- 
Mike Kravetz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Davidlohr Bueso <dave@stgolabs.net> - 2015-07-23 00:30 +0200
  Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Andrew Morton <akpm@linux-foundation.org> - 2015-07-23 00:40 +0200
    Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Andrew Morton <akpm@linux-foundation.org> - 2015-07-23 00:40 +0200
      Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Davidlohr Bueso <dave@stgolabs.net> - 2015-07-23 01:00 +0200
        Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Davidlohr Bueso <dave@stgolabs.net> - 2015-07-23 01:00 +0200
    Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Davidlohr Bueso <dave@stgolabs.net> - 2015-07-23 00:40 +0200
    Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Mike Kravetz <mike.kravetz@oracle.com> - 2015-07-23 01:30 +0200
      Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Davidlohr Bueso <dave@stgolabs.net> - 2015-07-23 02:00 +0200
        Re: [PATCH v4 00/10] hugetlbfs: add fallocate support David Rientjes <rientjes@google.com> - 2015-07-23 02:10 +0200
      Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Mike Kravetz <mike.kravetz@oracle.com> - 2015-07-23 19:10 +0200
        Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Eric B Munson <emunson@akamai.com> - 2015-07-23 19:20 +0200
          Re: [PATCH v4 00/10] hugetlbfs: add fallocate support Mike Kravetz <mike.kravetz@oracle.com> - 2015-07-23 19:40 +0200

csiph-web