Groups > linux.kernel > #1190345

Re: [PATCH] Fix data loss in cdc-acm

From	Sven Brauch <mail@svenbrauch.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fix data loss in cdc-acm
Date	2015-07-23 01:00 +0200
Message-ID	<pPb9v-51T-7@gated-at.bofh.it> (permalink)
References	(3 earlier) <pOG5J-1v3-41@gated-at.bofh.it> <pONAe-3PG-1@gated-at.bofh.it> <pOPiI-6k0-39@gated-at.bofh.it> <pOQop-7Ps-3@gated-at.bofh.it> <pPawN-4jc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On 23/07/15 00:12, Peter Hurley wrote:
> The premature unthrottle actually leads to the data loss but the throttling
> with a mere 2K left is _way too late_.
Ok, yes, I think so too.

> 10ms is a _really_ long time for a cpu not to attend to a kworker.
> Which raises 2 questions:
> 1. What are the termios settings of the tty receiving input? Is it 'raw'
>    mode or typical terminal mode (icanon, echo, etc.) or something else?
In my test code, I open the tty like
  fd = open("/dev/ttyACM0", O_RDWR | O_NOCTTY | O_NONBLOCK);
I don't make any other changes to the default settings. To be honest,
I'm not sure in which mode it is operating then (I was assuming raw, but
I might be wrong?).

> 2. Are there RT threads that are hogging cpu time?
I can't see any, I think the only thing which occasionally goes to RT is
pulseaudio (but during at least some of the tests I wasn't even playing
audio, so that sounds very unplausible to me). I also cannot see a
correlation between failure rate and CPU load.

Best regards,
Sven

Thread

[PATCH] Fix data loss in cdc-acm Sven Brauch <mail@svenbrauch.de> - 2015-07-19 23:50 +0200
  Re: [PATCH] Fix data loss in cdc-acm Johan Hovold <johan@kernel.org> - 2015-07-20 19:30 +0200
    Re: [PATCH] Fix data loss in cdc-acm Sven Brauch <mail@svenbrauch.de> - 2015-07-20 20:10 +0200
      Re: [PATCH] Fix data loss in cdc-acm Oliver Neukum <oneukum@suse.com> - 2015-07-22 10:50 +0200
        Re: [PATCH] Fix data loss in cdc-acm Peter Hurley <peter@hurleysoftware.com> - 2015-07-22 16:40 +0200
          Re: [PATCH] Fix data loss in cdc-acm Oliver Neukum <oneukum@suse.com> - 2015-07-22 17:10 +0200
      Re: [PATCH] Fix data loss in cdc-acm Sven Brauch <mail@svenbrauch.de> - 2015-07-23 01:00 +0200
        Re: [PATCH] Fix data loss in cdc-acm Peter Stuge <peter@stuge.se> - 2015-07-27 12:10 +0200

csiph-web