Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1191828

[PATCH 3/6] iio: trigger: Add missing fields in kernel docs

Show all headers | View raw

Fix kernel docs warnings by adding the missing description
for each of the existing function parameters.

Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
---
 drivers/iio/industrialio-trigger.c | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
index d31098e..cae2939 100644
--- a/drivers/iio/industrialio-trigger.c
+++ b/drivers/iio/industrialio-trigger.c
@@ -40,7 +40,14 @@ static DEFINE_MUTEX(iio_trigger_list_lock);
 
 /**
  * iio_trigger_read_name() - retrieve useful identifying name
- **/
+ * @dev:	device that holds the iio_trigger
+ * @attr:	pointer to the device_attribute structure that is
+ *		being processed
+ * @buf:	buffer to print the name into
+ *
+ * Return: a negative number on failure or the number of written
+ *	   characters on success.
+ */
 static ssize_t iio_trigger_read_name(struct device *dev,
 				     struct device_attribute *attr,
 				     char *buf)
@@ -288,10 +295,17 @@ EXPORT_SYMBOL_GPL(iio_dealloc_pollfunc);
 
 /**
  * iio_trigger_read_current() - trigger consumer sysfs query current trigger
+ * @dev:	Device this iio_dev belongs to
+ * @attr:	Pointer to the device_attribute structure that
+ *		is being processed
+ * @buf:	Buffer where the current trigger name will be printed into
  *
  * For trigger consumers the current_trigger interface allows the trigger
  * used by the device to be queried.
- **/
+ *
+ * Return: a negative number on failure, the number of characters written
+ *	   on success or 0 if no trigger is available
+ */
 static ssize_t iio_trigger_read_current(struct device *dev,
 					struct device_attribute *attr,
 					char *buf)
@@ -305,11 +319,18 @@ static ssize_t iio_trigger_read_current(struct device *dev,
 
 /**
  * iio_trigger_write_current() - trigger consumer sysfs set current trigger
+ * @dev:	Device that this iio_dev belongs to
+ * @attr:	Device attribute that is being processed
+ * @buf:	String buffer that holds the name of the trigger
+ * @len:	Length of the trigger name held by buf
  *
  * For trigger consumers the current_trigger interface allows the trigger
  * used for this device to be specified at run time based on the trigger's
  * name.
- **/
+ *
+ * Return: negative error code on failure or length of the buffer
+ *	   on success
+ */
 static ssize_t iio_trigger_write_current(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] iio: Fix kernel docs warnings Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:20 +0200
  [PATCH 2/6] iio: buffer: Fix kernel docs warnings Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:20 +0200
    Re: [PATCH 2/6] iio: buffer: Fix kernel docs warnings Hartmut Knaack <knaack.h@gmx.de> - 2015-08-02 21:40 +0200
      Re: [PATCH 2/6] iio: buffer: Fix kernel docs warnings Hartmut Knaack <knaack.h@gmx.de> - 2015-08-02 21:50 +0200
        Re: [PATCH 2/6] iio: buffer: Fix kernel docs warnings Cristina Georgiana Opriceana <cristina.opriceana@gmail.com> - 2015-08-03 12:50 +0200
    Re: [PATCH 2/6] iio: buffer: Fix kernel docs warnings Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:30 +0200
  [PATCH 1/6] iio: core: Add function params for kernel docs Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:20 +0200
    Re: [PATCH 1/6] iio: core: Add function params for kernel docs Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:30 +0200
  [PATCH 3/6] iio: trigger: Add missing fields in kernel docs Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:30 +0200
    Re: [PATCH 3/6] iio: trigger: Add missing fields in kernel docs Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:40 +0200
  [PATCH 5/6] include: linux: iio: Fix function parameter name in  kernel doc Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:30 +0200
    Re: [PATCH 5/6] include: linux: iio: Fix function parameter name in  kernel doc Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:40 +0200
  [PATCH 6/6] include: linux: iio: Add missing kernel doc field Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:30 +0200
    Re: [PATCH 6/6] include: linux: iio: Add missing kernel doc field Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:40 +0200
  [PATCH 4/6] iio: event: Add missing fields in kernel docs Cristina Opriceana <cristina.opriceana@gmail.com> - 2015-07-24 15:30 +0200
    Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs Hartmut Knaack <knaack.h@gmx.de> - 2015-08-02 21:50 +0200
      Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs Lars-Peter Clausen <lars@metafoo.de> - 2015-08-03 11:10 +0200
      Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs Cristina Georgiana Opriceana <cristina.opriceana@gmail.com> - 2015-08-03 11:10 +0200
    Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs Jonathan Cameron <jic23@kernel.org> - 2015-08-02 19:40 +0200

csiph-web