Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1191805

Re: [PATCH] power_supply: Adjust devm usage

From Sebastian Reichel <sre@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] power_supply: Adjust devm usage
Date 2015-07-24 15:10 +0200
Message-ID <pPKTF-6EB-13@gated-at.bofh.it> (permalink)
References <pPJNV-4T4-29@gated-at.bofh.it> <pPKgX-5Gn-29@gated-at.bofh.it> <pPKqD-5RA-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Jul 24, 2015 at 02:39:12PM +0200, Frans Klaver wrote:
> On Fri, Jul 24, 2015 at 2:26 PM, Sebastian Reichel <sre@kernel.org> wrote:
> > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote:
> >> Use devm_kasprintf instead of kasprintf. Also, remove various
> >> gotos by direct returns and drop unneeded label err_free_name.
> >
> > Please also use devm_power_supply_unregister() instead
> > of power_supply_unregister() to further simplify the driver.
> 
> Sounds like a separate patch.

I would be fine with either one or two patches. It's common, that
devm conversion happens in one commit instead of one patch per
function change.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power_supply: Adjust devm usage Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-07-24 14:00 +0200
  Re: [PATCH] power_supply: Adjust devm usage Frans Klaver <fransklaver@gmail.com> - 2015-07-24 14:20 +0200
    Re: [PATCH] power_supply: Adjust devm usage Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-24 14:30 +0200
      Re: [PATCH] power_supply: Adjust devm usage Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-07-24 14:40 +0200
  Re: [PATCH] power_supply: Adjust devm usage Sebastian Reichel <sre@kernel.org> - 2015-07-24 14:30 +0200
    Re: [PATCH] power_supply: Adjust devm usage Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-07-24 14:40 +0200
      Re: [PATCH] power_supply: Adjust devm usage Sebastian Reichel <sre@kernel.org> - 2015-07-24 15:10 +0200
        Re: [PATCH] power_supply: Adjust devm usage Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-07-24 15:20 +0200
          Re: [PATCH] power_supply: Adjust devm usage Sebastian Reichel <sre@kernel.org> - 2015-07-24 15:40 +0200
            Re: [PATCH] power_supply: Adjust devm usage Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-07-24 15:50 +0200
    Re: [PATCH] power_supply: Adjust devm usage Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-24 14:40 +0200
    Re: [PATCH] power_supply: Adjust devm usage Frans Klaver <fransklaver@gmail.com> - 2015-07-24 14:40 +0200
      Re: [PATCH] power_supply: Adjust devm usage Sebastian Reichel <sre@kernel.org> - 2015-07-24 15:10 +0200
  Re: [PATCH] power_supply: Adjust devm usage Pavel Machek <pavel@ucw.cz> - 2015-08-02 09:00 +0200
    Re: [PATCH] power_supply: Adjust devm usage Sebastian Reichel <sre@kernel.org> - 2015-08-03 19:40 +0200

csiph-web