Groups > linux.kernel > #1191801

Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator

From	Henry Chen <HenryC.Chen@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator
Date	2015-07-24 15:10 +0200
Message-ID	<pPKTD-6EB-3@gated-at.bofh.it> (permalink)
References	<pPE1P-4X1-3@gated-at.bofh.it> <pPE1Q-4X1-9@gated-at.bofh.it> <pPGGl-oT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Javier,

On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote:
> Hello Henry,
> 
> I believe Mark asked you to use a subject lines reflecting the style
> for the subsystem, so the subject should had been something like:
> 
> regulators: mt6311: Add DT binding document
> 
> On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen@mediatek.com> wrote:
> > This patch adds a list of supported regulator names to the devicetree
> > binding documentation for Mediatek MT6311 PMIC.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> 
> I know is in your cover letter, but usually is good to also include a
> history log of the changes for each patch so people know what changed.
> Everything between the '---' and the diff are omitted by tools like
> git am so you can add there.  You can use tools like patman that do
> this automatically for you.
> 
Ok, got it, I will follow that.

> Also, I said that you could add my Reviewed-by after the node name
> change so you should had carried that. So again:

Sorry, did you mean I need to resent again?

Thanks for advise.
Henry

> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,
> Javier


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for  mt6311 regulator Javier Martinez Canillas <javier@dowhile0.org> - 2015-07-24 10:40 +0200
  Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for  mt6311 regulator Henry Chen <HenryC.Chen@mediatek.com> - 2015-07-24 15:10 +0200
    Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for  mt6311 regulator Javier Martinez Canillas <javier@dowhile0.org> - 2015-07-24 15:20 +0200

csiph-web