Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1191725

[PATCH] kdbus: fix sparse address-space annotation

Show all headers | View raw

Make sure to properly annotate casts in 'struct iovec' if we cross
address-spaces, to make sure sparse does not warn about them.

All those conversions are fine, as we are allowed to pass those kvecs
through the iovec importer.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 ipc/kdbus/message.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipc/kdbus/message.c b/ipc/kdbus/message.c
index 3520f45..27a5021 100644
--- a/ipc/kdbus/message.c
+++ b/ipc/kdbus/message.c
@@ -920,7 +920,7 @@ struct kdbus_pool_slice *kdbus_staging_emit(struct kdbus_staging *staging,
 
 	/* msg.size */
 	v->iov_len = sizeof(msg_size);
-	v->iov_base = &msg_size;
+	v->iov_base = (void __user *)&msg_size;
 	++v;
 
 	/* msg (after msg.size) plus items */
@@ -937,7 +937,7 @@ struct kdbus_pool_slice *kdbus_staging_emit(struct kdbus_staging *staging,
 	if (meta_size > 0) {
 		/* metadata items */
 		v->iov_len = meta_size;
-		v->iov_base = meta_items;
+		v->iov_base = (void __user *)meta_items;
 		++v;
 
 		/* padding after metadata */
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] kdbus: fix sparse address-space annotation David Herrmann <dh.herrmann@gmail.com> - 2015-07-24 13:10 +0200

csiph-web