Groups > linux.kernel > #1191693

Re: [PATCH v2 13/20] xen/events: fifo: Make it running on 64KB granularity

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	David Vrabel <david.vrabel@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 13/20] xen/events: fifo: Make it running on 64KB granularity
Date	Fri, 24 Jul 2015 12:40:01 +0200
Message-ID	<pPIyt-3am-3@gated-at.bofh.it> (permalink)
References	<pKqVz-4Ye-3@gated-at.bofh.it> <pKqVC-4Ye-59@gated-at.bofh.it>
X-Original-To	Julien Grall <julien.grall@citrix.com>, <xen-devel@lists.xenproject.org>
X-Ironport-Av	E=Sophos;i="5.15,538,1432598400"; d="scan'208";a="287214904"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
X-Dlp	MIA2
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-arm-kernel@lists.infradead.org>, <ian.campbell@citrix.com>, <stefano.stabellini@eu.citrix.com>, <linux-kernel@vger.kernel.org>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
X-Original-Date	Fri, 24 Jul 2015 11:36:23 +0100
X-Original-Message-ID	<55B21527.4010601@citrix.com>
X-Original-References	<1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-14-git-send-email-julien.grall@citrix.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1191693

Show key headers only | View raw

On 09/07/15 21:42, Julien Grall wrote:
> Only use the first 4KB of the page to store the events channel info. It
> means that we will wast 60KB every time we allocate page for:
>      * control block: a page is allocating per CPU
>      * event array: a page is allocating everytime we need to expand it

Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> 
> I think we can reduce the memory waste for the 2 areas by:
> 
>     * control block: sharing between multiple vCPUs. Although it will
>     require some bookkeeping in order to not free the page when the CPU
>     goes offline and the other CPUs sharing the page still there
> 
>     * event array: always extend the array event by 64K (i.e 16 4K
>     chunk). That would require more care when we fail to expand the
>     event channel.

I would extend it by 4 KiB each time but only allocate a new page every
16 times.  This minimizes the resources used in Xen.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 13/20] xen/events: fifo: Make it running on 64KB granularity David Vrabel <david.vrabel@citrix.com> - 2015-07-24 12:40 +0200

csiph-web