Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1191655

Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition

From Julien Grall <julien.grall@citrix.com>
Newsgroups linux.kernel
Subject Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition
Date 2015-07-24 12:00 +0200
Message-ID <pPHVN-2bg-23@gated-at.bofh.it> (permalink)
References <pKqVz-4Ye-3@gated-at.bofh.it> <pKqVA-4Ye-15@gated-at.bofh.it> <pPHsK-1CX-15@gated-at.bofh.it> <pPHM5-1ZQ-7@gated-at.bofh.it> <pPHM5-1ZQ-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 24/07/15 10:48, David Vrabel wrote:
> On 24/07/15 10:39, Julien Grall wrote:
>> Hi David,
>>
>> On 24/07/15 10:28, David Vrabel wrote:
>>> On 09/07/15 21:42, Julien Grall wrote:
>>>> The Xen hypercall interface is always using 4K page granularity on ARM
>>>> and x86 architecture.
>>>>
>>>> With the incoming support of 64K page granularity for ARM64 guest, it
>>>> won't be possible to re-use the Linux page definition in Xen drivers.
>>>>
>>>> Introduce Xen page definition helpers based on the Linux page
>>>> definition. They have exactly the same name but prefixed with
>>>> XEN_/xen_ prefix.
>>>>
>>>> Also modify page_to_pfn to use new Xen page definition.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>>> Cc: David Vrabel <david.vrabel@citrix.com>
>>>> ---
>>>>     I'm wondering if we should drop page_to_pfn has the macro will likely
>>>>     misuse when Linux is using 64KB page granularity.
>>>
>>> I think we want xen_gfn_to_page() and xen_page_to_gfn() and Xen
>>> front/back drivers never deal with PFNs only GFNs.
>>
>> What is xen_gfn_to_page and xen_page_to_gfn? Neither Linux, nor my
>> series have them.
> 
> I suggesting that you introduce these.

It's still not clear to me what you are suggesting here... Do you
suggest to rename xen_pfn_to_page and xen_page_to_pfn by xen_gfn_to_page
and xen_page_to_gfn?

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition David Vrabel <david.vrabel@citrix.com> - 2015-07-24 11:30 +0200
  Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition David Vrabel <david.vrabel@citrix.com> - 2015-07-24 11:50 +0200
    Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition Julien Grall <julien.grall@citrix.com> - 2015-07-24 12:00 +0200
      Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition David Vrabel <david.vrabel@citrix.com> - 2015-07-24 12:40 +0200
        Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page  definition Ian Campbell <ian.campbell@citrix.com> - 2015-07-24 12:50 +0200
        Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition Julien Grall <julien.grall@citrix.com> - 2015-07-24 15:10 +0200
  Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition Julien Grall <julien.grall@citrix.com> - 2015-07-24 11:50 +0200

csiph-web