Groups > linux.kernel > #1191606

Re: [PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Matthias Brugger <matthias.bgg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings
Date	Fri, 24 Jul 2015 10:50:01 +0200
Message-ID	<pPGQ1-Az-9@gated-at.bofh.it> (permalink)
References	<pOesO-3Zl-9@gated-at.bofh.it> <pOesO-3Zl-27@gated-at.bofh.it>
X-Original-To	YH Huang <yh.huang@mediatek.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=0r1ahfAuqP95wR2gFCUVVcV3HeX2Hphp9thpc1Hge1U=; b=y4cG68lm6FV1071OiuKcOrzbmop8a5L+l+/mqPPxDYBlzG3wczGhayphMW7amKcDVj xgzxK1AfRK1RbF9/pVbojrQC9ylpy70HARaQvnmTPKaoGMhAlWxYZHtulcALZpT5Dg3R wOMJ/5CgrQOZeIrK4vgaNi8K6vYc/Y7OP0y9073Iy51ByjsRHxmvd6SdeWDP4J7XeWs/ RdqYm0do0zE49FyvFsde8JQhp1lzGvspZnau7NLLOLYcm7FHBrvevm/ZEy+LoYCoYxrt J+w+NGryutecZwJPjgE2mw2bNQgwrAHDvqTmryXxD3zg4o5BrDonFEeObk6sFJxpyeJf UbaQ==
X-Received	by 10.194.84.179 with SMTP id a19mr23745579wjz.29.1437727254377; Fri, 24 Jul 2015 01:40:54 -0700 (PDT)
User-Agent	KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Mark Rutland <mark.rutland@arm.com>, Thierry Reding <thierry.reding@gmail.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Sascha Hauer <kernel@pengutronix.de>, yingjoe.chen@mediatek.com
X-Original-Date	Fri, 24 Jul 2015 10:40:31 +0200
X-Original-Message-ID	<8769951.Y5Edyg2WDJ@ubix>
X-Original-References	<1437380237-28961-1-git-send-email-yh.huang@mediatek.com> <1437380237-28961-2-git-send-email-yh.huang@mediatek.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1191606

Show key headers only | View raw

On Monday, July 20, 2015 04:17:15 PM YH Huang wrote:
> Document the device-tree binding of MediatTek display PWM.
> The PWM has one channel to control the backlight brightness for display.
> It supports MT8173 and MT6595.
> 
> Signed-off-by: YH Huang <yh.huang@mediatek.com>
> ---
>  .../devicetree/bindings/pwm/pwm-mtk-disp.txt       | 42
> ++++++++++++++++++++++ 1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt new file mode
> 100644
> index 0000000..f8f59ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> @@ -0,0 +1,42 @@
> +MediaTek display PWM controller
> +
> +Required properties:
> + - compatible: should be "mediatek,<name>-disp-pwm":
> +   - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
> +   - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.

I had another look on the mt6589 datasheet and for me it doesn't look like as 
if this drivers is compatible to mt6589.

DISP_PWM_CON_0 offset 0x10 maps to interrupt enable register and 
DISP_PWM_CON_1 offset 0x14 maps to interrupt status register.

This looks wrong to me, as you use both registers to write clock divider and 
clock period.

Regarding that this is v6 of the patch set, I would propose that you just drop 
the compatible string for mt6589 or you implement the register offset on basis 
of the compatible string so that mt6589 can you the driver as well.

Best regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings Matthias Brugger <matthias.bgg@gmail.com> - 2015-07-24 10:50 +0200
  Re: [PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings Daniel Kurtz <djkurtz@chromium.org> - 2015-07-24 11:10 +0200
    Re: [PATCH v6 1/3] dt-bindings: pwm: add MediaTek display PWM bindings Matthias Brugger <matthias.bgg@gmail.com> - 2015-07-24 15:00 +0200

csiph-web