Groups > linux.kernel > #1190100

Re: perf: multiplexing broken on amd fam16h?

From	Vince Weaver <vincent.weaver@maine.edu>
Newsgroups	linux.kernel
Subject	Re: perf: multiplexing broken on amd fam16h?
Date	2015-07-22 18:50 +0200
Message-ID	<pP5ns-45X-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <pP1jQ-6Jj-17@gated-at.bofh.it> <pP3EZ-1wt-3@gated-at.bofh.it> <pP3EZ-1wt-1@gated-at.bofh.it> <pP3OG-1Xp-17@gated-at.bofh.it> <pP4rn-2L3-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 22 Jul 2015, Peter Zijlstra wrote:

> On Wed, Jul 22, 2015 at 05:06:24PM +0200, Peter Zijlstra wrote:
> > On Wed, Jul 22, 2015 at 11:02:21AM -0400, Vince Weaver wrote:
> > > On Wed, 22 Jul 2015, Vince Weaver wrote:
> > > > 
> > > > OK, so I have to admit I'm a bit weak on ftrace.  What type of command 
> > > > line are you interested in seeing?  The ones I've tried with trace-cmd
> > > > have  activated  your trace_printks but there's 500MB of other data mixed 
> > > > in so maybe I am doing something wrong.
> > > 
> > > maybe the "nop" plugin was what I wanted.  I've posted the trace with that 
> > > here:
> > > 
> > > http://web.eece.maine.edu/~vweaver/junk/jaguar.mpx.out.gz
> > 
> > OK, that looks about right, lemme to stare at that.
> 
> Does this help?

yes, with this applied the check_multiplex test passes.

Vince


> 
> ---
>  kernel/events/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index d3dae3419b99..10d076b2572c 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -1868,8 +1868,6 @@ event_sched_in(struct perf_event *event,
>  
>  	perf_pmu_disable(event->pmu);
>  
> -	event->tstamp_running += tstamp - event->tstamp_stopped;
> -
>  	perf_set_shadow_time(event, ctx, tstamp);
>  
>  	perf_log_itrace_start(event);
> @@ -1881,6 +1879,8 @@ event_sched_in(struct perf_event *event,
>  		goto out;
>  	}
>  
> +	event->tstamp_running += tstamp - event->tstamp_stopped;
> +
>  	if (!is_software_event(event))
>  		cpuctx->active_oncpu++;
>  	if (!ctx->nr_active++)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: perf: multiplexing broken on amd fam16h? Peter Zijlstra <peterz@infradead.org> - 2015-07-22 14:30 +0200
  Re: perf: multiplexing broken on amd fam16h? Vince Weaver <vincent.weaver@maine.edu> - 2015-07-22 17:00 +0200
    Re: perf: multiplexing broken on amd fam16h? Peter Zijlstra <peterz@infradead.org> - 2015-07-22 17:10 +0200
      Re: perf: multiplexing broken on amd fam16h? Peter Zijlstra <peterz@infradead.org> - 2015-07-22 17:50 +0200
        Re: perf: multiplexing broken on amd fam16h? Vince Weaver <vincent.weaver@maine.edu> - 2015-07-22 18:50 +0200
  Re: perf: multiplexing broken on amd fam16h? Vince Weaver <vincent.weaver@maine.edu> - 2015-07-22 17:00 +0200
    Re: perf: multiplexing broken on amd fam16h? Peter Zijlstra <peterz@infradead.org> - 2015-07-22 17:10 +0200

csiph-web