Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Mel Gorman <mgorman@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature
Date	Wed, 22 Jul 2015 16:10:02 +0200
Message-ID	<pP2SC-Cp-29@gated-at.bofh.it> (permalink)
References	<pN7D3-666-3@gated-at.bofh.it> <pObbz-7CR-7@gated-at.bofh.it> <pOeCt-4aD-7@gated-at.bofh.it> <pOlXk-6kl-9@gated-at.bofh.it> <pOnw5-8oH-7@gated-at.bofh.it> <pP1Wx-7Id-21@gated-at.bofh.it>
X-Original-To	PINTU KUMAR <pintu.k@samsung.com>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-15
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	akpm@linux-foundation.org, corbet@lwn.net, vbabka@suse.cz, gorcunov@openvz.org, mhocko@suse.cz, emunson@akamai.com, kirill.shutemov@linux.intel.com, standby24x7@gmail.com, hannes@cmpxchg.org, vdavydov@parallels.com, hughd@google.com, minchan@kernel.org, tj@kernel.org, rientjes@google.com, xypron.glpk@gmx.de, dzickus@redhat.com, prarit@redhat.com, ebiederm@xmission.com, rostedt@goodmis.org, uobergfe@redhat.com, paulmck@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com, ddstreet@ieee.org, sasha.levin@oracle.com, koct9i@gmail.com, cj@linux.com, opensource.ganesh@gmail.com, vinmenon@codeaurora.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, qiuxishi@huawei.com, Valdis.Kletnieks@vt.edu, cpgs@samsung.com, pintu_agarwal@yahoo.com, vishnu.ps@samsung.com, rohit.kr@samsung.com, iqbal.ams@samsung.com, pintu.ping@gmail.com, pintu.k@outlook.com
X-Original-Date	Wed, 22 Jul 2015 15:05:30 +0100
X-Original-Message-ID	<20150722140530.GK2561@suse.de>
X-Original-References	<1437114578-2502-1-git-send-email-pintu.k@samsung.com> <1437366544-32673-1-git-send-email-pintu.k@samsung.com> <20150720082810.GG2561@suse.de> <02c601d0c306$f86d30f0$e94792d0$@samsung.com> <20150720175538.GJ2561@suse.de> <05af01d0c47f$3337ccd0$99a76670$@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1189977

Show key headers only | View raw

On Wed, Jul 22, 2015 at 06:33:26PM +0530, PINTU KUMAR wrote:
> Dear Mel, thank you very much for your comments and suggestions.
> I will drop this one and look on further improving direct_reclaim and
> compaction.
> Just few more comments below before I close.
> 
> Also, during this patch, I feel that the hibernation_mode part in
> shrink_all_memory can be corrected.
> So, can I separately submit the below patch?
> That is instead of hard-coding the hibernation_mode, we can get hibernation
> status using:
> system_entering_hibernation()
> 
> Please let me know your suggestion about this changes.
> 
> -#ifdef CONFIG_HIBERNATION
> +#if defined CONFIG_HIBERNATION || CONFIG_SHRINK_MEMORY

This appears to be a patch on top of "Add /proc/sys/vm/shrink_memory
feature" so I do not see what would be separately submitted that would
make sense.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHv2 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature Pintu Kumar <pintu.k@samsung.com> - 2015-07-17 08:50 +0200
  RE: [PATCHv2 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory  feature PINTU KUMAR <pintu.k@samsung.com> - 2015-07-17 09:10 +0200
  Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory  feature Mel Gorman <mgorman@suse.de> - 2015-07-20 20:00 +0200
    RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory  feature PINTU KUMAR <pintu.k@samsung.com> - 2015-07-22 15:10 +0200
      Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory  feature Mel Gorman <mgorman@suse.de> - 2015-07-22 16:10 +0200
        RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory  feature PINTU KUMAR <pintu.k@samsung.com> - 2015-07-29 07:20 +0200

csiph-web