Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1189877

Re: [PATCH V3] x86/mm/pat: Do a small optimization and fix in reserve_memtype

Show all headers | View raw

hi, Borislav
	thanks for your reply. :)

On 2015年07月22日 18:46, Borislav Petkov wrote:
> On Wed, Jul 22, 2015 at 05:06:04PM +0800, Pan Xinhui wrote:
>> how about:
>> memtype_lock protects the rb-tree root and the rb-nodes which is a field of memtype from delete/add/lookup in a race.
> 
> Use this:
> 
> "All pat_rbtree operations need to be performed while holding the
> memtype_lock."
> 
thanks!

>> Actually I have same questions. I find these output logs are added in
>> commit: 6997ab4982a29925e79f72c3a59823cf944c3529(x86: add PAT related
>> debug prints) In the past, *new_type == actual_type == new->type on
>> success. codes are below. author use actual_type there.
> 
> So this function is one bit PITA. So req_type is used to compute actual
> type a bit higher:
> 
> 	actual_type = pat_x_mtrr_type(start, end, req_type);
> 
> and from then on actual_type is being used.
> 
> BUT!, in order to have *all* debugging information, the last dprintk()
agree, output all debugging information.

> call should dump actual_type and req_type because this way we show what
then why not append "act %s" to the dprintk format string?

> pat_x_mtrr_type() did too. And we don't need to dump new->type because
> this is the !err case and in that case we assigned new_type to it, which
> we dump already.
yes, new->type is same with *new_type, and dump same value twice.

> 
> Ok?
> 
Let me think for a while. I wonder why there is not any comment that could tell developers what "track %s" mean.
In different places of this file, "track %s" can mean what type of memory it is now, or it used to be.

So I think this output filed "track %s" is just whatever people want to need to print out.

I prefer to dump all debugging information here, so I agree with your idea. thanks

> Btw, you could also simplify this:
> 
> 	if (is_range_ram == 1) {
> 
> 		err = reserve_ram_pages_type(start, end, req_type, new_type);
> 
> 		return err;
> 	}
> 
> to:
> 
> 	if (is_range_ram == 1)
> 		return reserve_ram_pages_type(start, end, req_type, new_type);
> 
seems better now, thanks!
> while at it.
> 
> Thanks.
> 

thanks
xinhui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] x86/mm/pat: Do a small optimization and fix in reserve_memtype Pan Xinhui <xinhuix.pan@intel.com> - 2015-07-22 07:50 +0200
  Re: [PATCH V3] x86/mm/pat: Do a small optimization and fix in  reserve_memtype Borislav Petkov <bp@alien8.de> - 2015-07-22 09:50 +0200
    Re: [PATCH V3] x86/mm/pat: Do a small optimization and fix in reserve_memtype Pan Xinhui <xinhuix.pan@intel.com> - 2015-07-22 15:00 +0200

csiph-web