Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node field

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node field
Date	Wed, 22 Jul 2015 14:50:01 +0200
Message-ID	<pP1Db-765-9@gated-at.bofh.it> (permalink)
References	<pOCEN-5bW-7@gated-at.bofh.it> <pOCEN-5bW-5@gated-at.bofh.it> <pOWNc-d3-13@gated-at.bofh.it> <pOX6y-zY-7@gated-at.bofh.it> <pOX6y-zY-11@gated-at.bofh.it>
X-Original-To	Thomas Gleixner <tglx@linutronix.de>
Organization	ARM Ltd
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
X-Original-Cc	"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>, Jiang Liu <jiang.liu@linux.intel.com>, Jason Cooper <jason@lakedaemon.net>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Tomasz Nowicki <tomasz.nowicki@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>
X-Original-Date	Wed, 22 Jul 2015 13:43:34 +0100
X-Original-Message-ID	<55AF8FF6.3080901@arm.com>
X-Original-References	<1437473280-11431-1-git-send-email-marc.zyngier@arm.com> <1437473280-11431-2-git-send-email-marc.zyngier@arm.com> <55AF47D7.8010304@linaro.org> <55AF4BBA.5030209@arm.com> <alpine.DEB.2.11.1507220958090.18576@nanos>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1189874

Show key headers only | View raw

On 22/07/15 08:58, Thomas Gleixner wrote:
> On Wed, 22 Jul 2015, Marc Zyngier wrote:
>>
>> Looks like my coccinelle foo is still lacking a bit... Oh well.
> 
> Please post your semantic patch and don't forget to Cc Julia Lawall :)
> 

Bah, found the problem. My semantic patch is extremely simple:

@init@
struct irq_domain *ptr;
position pos;
@@

(
ptr@pos->of_node
)

@ script:python @
p1 << init.pos;
@@

for p in p1:
    print "%s:%s" % (p.file,p.line)

as I'm just grepping through the tree (I don't feel confident enough to
do the patching, and some cases are a bit more complicated).

But I forgot to add arch/$ARCH/include/asm as an include search path for
spatch. That had the side effect of spatch being unable to identify
constructs like:

arch/$ARCH/include/asm/foo.h:

	struct foo {
		struct irq_domain *bar;
	};

arch/$ARCH/.../foo.c:

	struct foo foo;
	if (foo->bar->of_node) { ... }

Since spatch knows nothing about struct foo, it cannot identify bar as a
struct irq_domain, hence missing this occurrence.

Once I fixed the include path, I found an additional couple of victims.
I really love this thing! :-)

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node  field Hanjun Guo <hanjun.guo@linaro.org> - 2015-07-22 09:40 +0200
  Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node  field Thomas Gleixner <tglx@linutronix.de> - 2015-07-22 10:00 +0200
  Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node  field Thomas Gleixner <tglx@linutronix.de> - 2015-07-22 10:00 +0200
    Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node  field Marc Zyngier <marc.zyngier@arm.com> - 2015-07-22 14:50 +0200
  Re: [PATCH 1/5] genirq: irqdomain: Use an accessor for the of_node  field Marc Zyngier <marc.zyngier@arm.com> - 2015-07-22 10:00 +0200

csiph-web