[PATCH 2/2] pinctrl: use dev_err() to show message in pinmux_func_name_to_selector()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] pinctrl: use dev_err() to show message in pinmux_func_name_to_selector()
Date	Tue, 21 Jul 2015 08:30:01 +0200
Message-ID	<pOzdT-bd-1@gated-at.bofh.it> (permalink)
References	<pOzdT-bd-3@gated-at.bofh.it>
X-Original-To	linux-gpio@vger.kernel.org
X-Nifty-Srcip	[14.14.81.130]
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Masahiro Yamada <yamada.masahiro@socionext.com>, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 21 Jul 2015 15:25:27 +0900
X-Original-Message-ID	<1437459927-5278-2-git-send-email-yamada.masahiro@socionext.com>
X-Original-References	<1437459927-5278-1-git-send-email-yamada.masahiro@socionext.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1188692

Show key headers only | View raw

Use dev_err() rather than pr_err() to display the error message.

pinctrl_dev_get_name(pctldev) is no longer necessary because
dev_err() shows which device the message is related to.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/pinctrl/pinmux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 766ec57..18ce18c 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -322,8 +322,7 @@ static int pinmux_func_name_to_selector(struct pinctrl_dev *pctldev,
 		selector++;
 	}
 
-	pr_err("%s does not support function %s\n",
-	       pinctrl_dev_get_name(pctldev), function);
+	dev_err(pctldev->dev, "function '%s' not supported\n", function);
 	return -EINVAL;
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/2] pinctrl: use dev_err() to show message in pinmux_func_name_to_selector() Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-07-21 08:30 +0200

csiph-web