RE: [PATCH V4 2/7] qup: i2c: factor out common code for reuse

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Sricharan" <sricharan@codeaurora.org>
Newsgroups	linux.kernel
Subject	RE: [PATCH V4 2/7] qup: i2c: factor out common code for reuse
Date	Tue, 21 Jul 2015 09:00:02 +0200
Message-ID	<pOzGW-Jw-13@gated-at.bofh.it> (permalink)
References	<pKaH7-3od-5@gated-at.bofh.it> <pKaH7-3od-3@gated-at.bofh.it> <pOeCu-4aD-13@gated-at.bofh.it>
X-Original-To	"'Ivan T. Ivanov'" <iivanov@mm-sol.com>
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8BIT
X-Mailer	Microsoft Outlook 15.0
Thread-Index	AQIhP+Z77323UyUNQOiucUIcbZiX1ACC7JHQARoJ24WdN5wIkA==
Content-Language	en-us
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <galak@codeaurora.org>, <linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>, <agross@codeaurora.org>, <dmaengine@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Tue, 21 Jul 2015 12:24:38 +0530
X-Original-Message-ID	<000001d0c382$2061ceb0$61256c10$@codeaurora.org>
X-Original-References	<1436412350-19519-1-git-send-email-sricharan@codeaurora.org> <1436412350-19519-3-git-send-email-sricharan@codeaurora.org> <1437380700.6267.1.camel@mm-sol.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1188710

Show key headers only | View raw

Hi Ivan,
  Thnaks for all the reviews.

> -----Original Message-----
> From: linux-arm-msm-owner@vger.kernel.org [mailto:linux-arm-msm-
> owner@vger.kernel.org] On Behalf Of Ivan T. Ivanov
> Sent: Monday, July 20, 2015 1:55 PM
> To: Sricharan R
> Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org;
> galak@codeaurora.org; linux-kernel@vger.kernel.org; linux-
> i2c@vger.kernel.org; agross@codeaurora.org; dmaengine@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V4 2/7] qup: i2c: factor out common code for reuse
> 
> 
> Hi Sricharan,
> 
> On Thu, 2015-07-09 at 08:55 +0530, Sricharan R wrote:
> >
> 
> >  static int qup_i2c_read_one(struct qup_i2c_dev *qup, struct i2c_msg
> > *msg)  {
> > -       unsigned long left;
> > -       int ret;
> > +       int ret = 0;
> >
> > -       qup->msg = msg;
> > -       qup->pos  = 0;
> > +       /*
> > +               * The QUP block will issue a NACK and STOP on the bus when
> reaching
> > +               * the end of the read, the length of the read is specified as one
> byte
> > +               * which limits the possible read to 256 (QUP_READ_LIMIT) bytes.
> > +               */
> > +       if (msg->len > QUP_READ_LIMIT) {
> > +               dev_err(qup->dev, "HW not capable of reads over %d bytes\n",
> > +                       QUP_READ_LIMIT);
> > +               return -EINVAL;
> > +       }
> >
> 
> This should be removed. Please see qup_i2c_quirks.
> 
  Ok get it, will remove this.

Regards,
 Sricharan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH V4 2/7] qup: i2c: factor out common code for reuse "Sricharan" <sricharan@codeaurora.org> - 2015-07-21 09:00 +0200

csiph-web