Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields
Date	2015-07-21 08:20 +0200
Message-ID	<pOz4d-8rH-7@gated-at.bofh.it> (permalink)
References	<pOmA3-73E-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Paolo Pisati <p.pisati@gmail.com> wrote:

> hd0_info and hd1_info are not used anymore, don't reference them in the code
> 
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
> ---
>  arch/x86/kernel/kexec-bzimage64.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
> index 3666a84..c0ae428 100644
> --- a/arch/x86/kernel/kexec-bzimage64.c
> +++ b/arch/x86/kernel/kexec-bzimage64.c
> @@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
>  	/* Default APM info */
>  	memset(&params->apm_bios_info, 0, sizeof(params->apm_bios_info));
>  
> -	/* Default drive info */
> -	memset(&params->hd0_info, 0, sizeof(params->hd0_info));
> -	memset(&params->hd1_info, 0, sizeof(params->hd1_info));
> -
>  	if (image->type == KEXEC_TYPE_CRASH) {
>  		ret = crash_setup_memmap_entries(image, params);
>  		if (ret)

But they are not unused: we pass them to secondary kernel images, via kcrash for 
example.

So it makes sense to zero out these parameters.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields Ingo Molnar <mingo@kernel.org> - 2015-07-21 08:20 +0200

csiph-web