Re: [PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer driver

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer driver
Date	2015-07-20 16:20 +0200
Message-ID	<pOk5b-3CG-11@gated-at.bofh.it> (permalink)
References	<pOjLQ-30h-3@gated-at.bofh.it> <pOjLQ-30h-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 20, 2015 at 04:52:30PM +0300, Teodora Baluta wrote:
> +static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo,
> +				  int index, int *val)
> +{
> +	switch (index) {
> +	case AXIS_X:
> +		*val = (raw[AXIS_X] - nfo) * 1000 / sens[AXIS_X];
> +		break;
> +	case AXIS_Y:
> +		*val = (raw[AXIS_Y] - nfo) * 1000 / sens[AXIS_Y];
> +		break;
> +	case AXIS_Z:
> +		*val = (raw[AXIS_Z] - nfo) * 1000 / sens[AXIS_Z];
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}

We never pass invalid indexes here so this could be replaced with:

static int mmc34160_raw_to_mgauss(int raw[3], int sens[3], int nfo,
				  int index, int *val)
{
	*val = (raw[index] - nfo) * 1000 / sens[index];
	return 0;
}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer driver Teodora Baluta <teodora.baluta@intel.com> - 2015-07-20 16:00 +0200
  Re: [PATCH v2 2/2] iio: magnetometer: add mmc34160 magnetometer  driver Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-20 16:20 +0200

csiph-web