Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1189717

[PATCH] hexdump: do not print debug dumps for !CONFIG_DEBUG

Show all headers | View raw

The function print_hex_dump_debug() is likely supposed to be
analogous to pr_debug() or dev_dbg() & friends. Currently it
will adhere to dynamic debug, but will not stub out prints if
CONFIG_DEBUG is not set. Let's make it do the right thing,
because I am tired of having my dmesg buffer full of hex
dumps on production systems.

Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Andrew: I think this is your file. I did spend some time
shaking my head thinking this basic thing just can't be wrong,
but it appears it is.
---
 include/linux/printk.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/linux/printk.h b/include/linux/printk.h
index a6298b27ac99..2d154b13d6cc 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -456,11 +456,17 @@ static inline void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
 			     groupsize, buf, len, ascii)	\
 	dynamic_hex_dump(prefix_str, prefix_type, rowsize,	\
 			 groupsize, buf, len, ascii)
-#else
+#elif defined(DEBUG)
 #define print_hex_dump_debug(prefix_str, prefix_type, rowsize,		\
 			     groupsize, buf, len, ascii)		\
 	print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize,	\
 		       groupsize, buf, len, ascii)
-#endif /* defined(CONFIG_DYNAMIC_DEBUG) */
+#else
+static inline void print_hex_dump_debug(const char *prefix_str, int prefix_type,
+					int rowsize, int groupsize,
+					const void *buf, size_t len, bool ascii)
+{
+}
+#endif
 
 #endif
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] hexdump: do not print debug dumps for !CONFIG_DEBUG Linus Walleij <linus.walleij@linaro.org> - 2015-07-22 10:00 +0200

csiph-web