Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

From	Vignesh R <vigneshr@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler
Date	2015-07-22 09:40 +0200
Message-ID	<pOWNc-d3-17@gated-at.bofh.it> (permalink)
References	<pBWrD-8bF-5@gated-at.bofh.it> <pBWrD-8bF-7@gated-at.bofh.it> <pDzKh-3yL-3@gated-at.bofh.it> <pE9NM-4Jk-19@gated-at.bofh.it> <pOAWn-2G0-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andreas,

On 07/21/2015 01:46 PM, Andreas Fenkart wrote:
> Hi Vignesh,
> 
> Generally I don't like this patch, it will make it harder, not easier,
> to maintain the omap hsmmc driver. Also given that the bug occurs
> rarely, people will be reluctant to clean it up later or accept
> patches.
> 
> see also comments below
> 
[snip]
> 2015-06-22 15:18 GMT+02:00 Vignesh R <vigneshr@ti.com>:
>>
> 
>> But calls to omap_hsmmc_card_init or omap_hsmmc_get_cd are in the same
>> mmc_rescan thread. Hence, moving the recovery code to init_card does not
>> help.
> 
> what about clearing any pending transfer in
> - mmc_gpio_cd_irqt, or
> - mmc_detect_change
> 
> e.g. trigger the later mentioned .card_event callback from those
> functions, instead mmc_rescan? Then you can install your
> omap_hsmmc_request_clear as the card_event callback. This makes your
> custom isr handler redundant, actually your isr handler became
> standard.
> 

I looked  at the commit fa372a51cb5f93800f711473e5a36e0e0c9a8f00 which
moved .card_event out of mmc_gpio_cd_irqt. It points to two threads
where discussion to move .card_event to mmc_rescan happened[1][2]. The
concern there was this callback was being called from "atomic context"
but, I don't understand how threaded irq is "atomic context". (I am not
sure, if this is because those drivers have irqs disabled till threaded
irq is complete) But, I believe moving card_event callback back to
mmc_gpio_cd_irqt may break some drivers.
I will look into this further.
Do you have any insight on this commit? Thanks!

[1]https://lkml.org/lkml/2014/3/19/79
[2]https://lkml.org/lkml/2013/8/19/539

-- 
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq  handler Vignesh R <vigneshr@ti.com> - 2015-07-22 09:40 +0200

csiph-web