Re: [PATCH] perf: fix makefile generation under dash

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf: fix makefile generation under dash
Date	2015-07-19 21:20 +0200
Message-ID	<pO2i0-3q1-73@gated-at.bofh.it> (permalink)
References	<pNTeG-7cR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 19, 2015 at 10:30:05AM +0100, Sergei Trofimovich wrote:
> Under dash 'echo -n' yields '-n' to stdout.
> Use printf "" instead.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Arnaldo Carvalho de Melo <acme@kernel.org>
> CC: Jiri Olsa <jolsa@redhat.com>
> CC: Namhyung Kim <namhyung@kernel.org>
> CC: Adrian Hunter <adrian.hunter@intel.com>
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <siarheit@google.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 094ddae..bc0b59e 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
>  obj-perf := $(abspath $(obj-perf))/
>  endif
>  
> -$(shell echo -n > $(OUTPUT).config-detected)
> +$(shell printf "" > $(OUTPUT).config-detected)
>  detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
>  detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>  
> -- 
> 2.4.6
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] perf: fix makefile generation under dash Jiri Olsa <jolsa@redhat.com> - 2015-07-19 21:20 +0200

csiph-web