Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

From	zhengxing <zhengxing@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec
Date	2015-07-18 06:30 +0200
Message-ID	<pNrV7-1M9-3@gated-at.bofh.it> (permalink)
References	<pMlyq-3ED-3@gated-at.bofh.it> <pMlyp-3ED-1@gated-at.bofh.it> <pNif9-4Cp-45@gated-at.bofh.it> <pNrs6-Xz-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>> +static int snd_rk_mc_remove(struct platform_device *pdev)
>>> +{
>>> +    struct snd_soc_card *soc_card = platform_get_drvdata(pdev);
>>> +
>>> +    snd_soc_card_set_drvdata(soc_card, NULL);
>>> +    snd_soc_unregister_card(soc_card);
>>> +    platform_set_drvdata(pdev, NULL);
>> No need for any of the _set_drvdata() calls, the core does them and they
>> shouldn't make any difference anyway.
> Done. I will remove *_set_drvdata and *get_drvdata because we don't 
> need them any more.
>
Sorry, I mean just remove platform_set_drvdata(pdev, NULL);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec zhengxing <zhengxing@rock-chips.com> - 2015-07-18 06:30 +0200

csiph-web