Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data

From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data
Date	2015-07-17 23:30 +0200
Message-ID	<pNlmG-yp-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <pMReX-7Jp-37@gated-at.bofh.it> <pNh9o-2Q8-27@gated-at.bofh.it> <pNhCq-3Dd-21@gated-at.bofh.it> <pNjkS-68R-7@gated-at.bofh.it> <pNjEd-6vh-1@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Fri, 17 Jul 2015 12:36:34 -0700, Guenter Roeck wrote:
> Hi Jean,
> 
> On 07/17/2015 12:11 PM, Jean Delvare wrote:
> 
> >
> > We could just drop NUM_REAL_CORES and use CONFIG_NR_CPUS instead, I
> > would be fine with that. This lets people worried about memory
> > consumption control it.
>
> Unfortunately this won't work because the CPU ID is non-linear;
> an 8-core system may have a CPU ID larger than 7.

Oh right, I forgot about that. Brilliant hardware/firmware engineers...

Well that does not prevent us from using CONFIG_NR_CPUS, "just" the
code would need to be modified to remove the assumption that the array
index matches the logical CPU ID.

BTW I wonder how the rest of the kernel handles the situation.
CONFIG_NR_CPUS is used where relevant so there certainly _is_ a linear
numbering which is independent from the CPU ID.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] hwmon: coretemp: use list instead of fixed size array  for temp data Jean Delvare <jdelvare@suse.de> - 2015-07-15 23:10 +0200
  Re: [PATCH] hwmon: coretemp: use list instead of fixed size array  for temp data Jean Delvare <jdelvare@suse.de> - 2015-07-17 23:30 +0200
  Re: [PATCH] hwmon: coretemp: use list instead of fixed size array  for temp data Jean Delvare <jdelvare@suse.de> - 2015-07-17 23:40 +0200

csiph-web