Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume
Date	2015-07-17 14:20 +0200
Message-ID	<pNcMp-59N-5@gated-at.bofh.it> (permalink)
References	<pMZvQ-2QD-15@gated-at.bofh.it> <pN9vc-kw-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Borislav Petkov <bp@alien8.de> wrote:

> >  EXPORT_SYMBOL_GPL(__static_cpu_has_safe);
> > +
> > +static void cpu_custom_resume(void)
> 
> Let's call this bsp_resume() as it is run only on the boot CPU.
> 
> > +{
> > +	if (this_cpu->c_resume)
> > +		this_cpu->c_resume(&boot_cpu_data);
> > +}
> 
> So giving boot_cpu_data means, this is the boot CPU but you're assigning it to 
> c_resume() which means, every CPU. What you could do is call the function ptr 
> ->c_bsp_resume like the ->c_bsp_init which we already have so that it is clear 
> that it is run only on the BSP.
> 
> Rest looks ok to me, unless tip guys have a better idea...

Looks good to me!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume Laura Abbott <labbott@fedoraproject.org> - 2015-07-17 00:10 +0200
  Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after  resume Borislav Petkov <bp@alien8.de> - 2015-07-17 10:50 +0200
    Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after  resume Ingo Molnar <mingo@kernel.org> - 2015-07-17 14:20 +0200

csiph-web