Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/6] staging: rtl8188eu: remove goto label
Date	2015-07-17 14:10 +0200
Message-ID	<pNcCK-4Yl-5@gated-at.bofh.it> (permalink)
References	<pMPwt-5cU-5@gated-at.bofh.it> <pMPwv-5cU-31@gated-at.bofh.it> <pNbGG-3Dh-11@gated-at.bofh.it> <pNc02-3ZN-15@gated-at.bofh.it> <pNcjo-4ml-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote:
> On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote:
> > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote:
> > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
> > > > By checking for the success of kzalloc we were able to remove the goto
> > > > label thus making the code more readable.
> > > > 
> > > 
> > > No...  You've just changed error handling to success handling and added
> > > some new indent levels and made a tangled spaghetti exit path even more
> > > tangled.  Spoderman wants to know, "Why u do dis?"
> > I had to go for google to lookup Spoderman or Spiderman. :)
> > At the end of the series, isn't the code better looking and simpler
> > than the original code?
> 
> Yes, but that's not a very high bar to clear.
> 
> What I'm trying to explain is the beauty of writing one statement after
> the other without indenting.
understood.
I was planning another series for that file so i will include one for
this also. But before that I am going to send in the patch for sm7xxfb
to move out of staging. Please check that.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] staging: rtl8188eu: remove goto label Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-16 13:30 +0200
  Re: [PATCH 3/6] staging: rtl8188eu: remove goto label Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-17 13:10 +0200
    Re: [PATCH 3/6] staging: rtl8188eu: remove goto label Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-17 13:30 +0200
      Re: [PATCH 3/6] staging: rtl8188eu: remove goto label Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-17 13:50 +0200
        Re: [PATCH 3/6] staging: rtl8188eu: remove goto label Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-17 14:10 +0200

csiph-web