Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime

From	Konstantin Khlebnikov <koct9i@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime
Date	2015-07-17 11:40 +0200
Message-ID	<pNahz-1uy-15@gated-at.bofh.it> (permalink)
References	<pM8hP-2CP-13@gated-at.bofh.it> <pM8hP-2CP-15@gated-at.bofh.it> <pMcY9-85n-5@gated-at.bofh.it> <pMeZZ-2zG-31@gated-at.bofh.it> <pMfMm-3Jp-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 15, 2015 at 12:18 AM, Christoph Lameter <cl@linux.com> wrote:
>
> On Tue, 14 Jul 2015, Konstantin Khlebnikov wrote:
>> > What breaks?
>>
>> The same commands from first patch:
>>
>> # echo 1 | tee /sys/kernel/slab/*/sanity_checks
>> # modprobe configfs
>>
>> loading configfs now fails (without crashing kernel though) because of
>> "sysfs: cannot create duplicate filename '/kernel/slab/:t-0000096'"
>
> Hrm.... Bad. Maybe drop the checks for the debug options that can be
> configured when merging slabs? They do not influence the object layout
> per definition.

I don't understand that. Debug options do changes in object layout.

Since they add significant performance overhead and cannot be undone in runtime
it's unlikely that anyone who uses them don't care about merging after that.
Also I don't see how merging could affect debugging in positive way
(except debugging bugs in merging logic itself).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime Konstantin Khlebnikov <koct9i@gmail.com> - 2015-07-14 22:30 +0200
  Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime Konstantin Khlebnikov <koct9i@gmail.com> - 2015-07-17 11:40 +0200

csiph-web