Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1186658
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] staging: dgap: fix error path |
| Date | Fri, 17 Jul 2015 12:00:01 +0200 |
| Message-ID | <pNaAV-1Rc-9@gated-at.bofh.it> (permalink) |
| References | <pMQVz-77l-3@gated-at.bofh.it> <pNahz-1uy-17@gated-at.bofh.it> |
| X-Original-To | Dan Carpenter <dan.carpenter@oracle.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=JSjMT9vPeh5xavtmFqZYOq+H+10JrKFJMI+W63TW8Lk=; b=JJ7phwMJeMOYEYy4k/R43TiiC7UAth2kZNTazBKl5TPGd3Fou01iVJhpKqJ4Ak0GUT Ek7fCIXjsPl0DouK/RpyLJAFxtOWSbkDjXel8CfDWyduit7eh1l6Gx0xERTAcDlx2gTh 1IOarZ/AxAqlg4NuozKHyrEAL5hFdOzd5N9qaIEFE7+fxAJlWyLwBj8qjOG+DitjCov4 g1nd48Q0cWs+bgWi05Wm/z3kvU+8AHM4fhDdi79+TOmWmAKwUZhJPElrhewIlSo8h3m0 Hp1RqHJWpphOOHh0N7OpuJrpxBRt3v+9ekGbZyiYnJ9l9ufzIPcfjtnzPrv8RT4Zehbt 7NPA== |
| X-Received | by 10.70.3.98 with SMTP id b2mr27758183pdb.107.1437126950956; Fri, 17 Jul 2015 02:55:50 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 17 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Lidza Louina <lidza.louina@gmail.com>, Mark Hounschell <markh@compro.net>, Daeseok Youn <daeseok.youn@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Fri, 17 Jul 2015 15:21:28 +0530 |
| X-Original-Message-ID | <20150717095128.GA3229@sudip-PC> |
| X-Original-References | <1437051500-20419-1-git-send-email-sudipm.mukherjee@gmail.com> <20150717093003.GA5371@mwanda> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1186658 |
Show key headers only | View raw
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote: > I don't think I like these at all. remove_one has always been buggy in > that it removes everything. We should fix it to only remove one instead > of formalizing the currect terrible behavior. Its already applied. I thought after the full series the code became a little better than the original one. Now dgap_stop() is being called from dgap_remove_one(). How do you suggest it should be? regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/4] staging: dgap: fix error path Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-17 11:40 +0200
Re: [PATCH 1/4] staging: dgap: fix error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-17 12:00 +0200
Re: [PATCH 1/4] staging: dgap: fix error path Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-17 12:10 +0200
Re: [PATCH 1/4] staging: dgap: fix error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-17 12:30 +0200
Re: [PATCH 1/4] staging: dgap: fix error path Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-17 13:00 +0200
csiph-web