Re: [RFC PATCH 04/21] x86/hweight: Add stack frame dependency for __arch_hweight*()

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 04/21] x86/hweight: Add stack frame dependency for __arch_hweight*()
Date	2015-07-19 06:20 +0200
Message-ID	<pNOf0-8uW-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <pNhM6-3Ot-13@gated-at.bofh.it> <pNsxP-2Ks-9@gated-at.bofh.it> <pNAF3-5ID-3@gated-at.bofh.it> <pNBKO-7eS-17@gated-at.bofh.it> <pNCGR-9f-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 18, 2015 at 10:57:14AM -0500, Josh Poimboeuf wrote:
> Currently, when stackvalidate sees an ALTERNATIVE, it assumes that
> either code path is possible, so it follows both paths in parallel.
> 
> If I understand right, you're proposing that stackvalidate should only
> follow the POPCNT path and never follow the !POPCNT path?

Actually, you don't even need to follow the POPCNT case either because
it is a single instruction - no stack operations there.

So yeah, either that or special-case the case where the original insn is
CALL and the replacement is a POPCNT and ignore those CALL locations.

The advantage is that the burden is put on the tool and not by adding
markers to kernel code paths.

> In general, I agree, and I like the original patch much better.  IMO, it
> achieved the goal of keeping the kernel code clean, while fixing the
> frame pointer bug.

And I think that in that case, adding that rSP dependency is too much
because even though it fixes the "bug", it is very very unlikely any
stack trace will have __sw_hweight* in it for reasons pointed out
earlier and also because those functions can't fail and they get
integral types as args which can't fail when deref-fing either. And even
if they do, they don't call any other functions so rIP pointing to them
is already enough.

So even if we're not 100% correct wrt stack traces in this case, I think
that's ok.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 04/21] x86/hweight: Add stack frame dependency for  __arch_hweight*() Borislav Petkov <bp@alien8.de> - 2015-07-18 07:10 +0200
  Re: [RFC PATCH 04/21] x86/hweight: Add stack frame dependency for  __arch_hweight*() Borislav Petkov <bp@alien8.de> - 2015-07-19 06:20 +0200

csiph-web