Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller

From	Paul Bolle <pebolle@tiscali.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller
Date	2015-07-17 11:10 +0200
Message-ID	<pN9Ox-X0-9@gated-at.bofh.it> (permalink)
References	<pMTgK-2eq-3@gated-at.bofh.it> <pMTgK-2eq-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote:
> --- /dev/null
> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c

> +static struct platform_driver atmel_qspi_driver = {
> +	.driver		= {
> +		[...]
> +		.bus	= &platform_bus_type,
> +		[...]
> +};
> +module_platform_driver(atmel_qspi_driver);

Nit: on module init this will basically do
    __platform_driver_register(&atmel_qspi_driver, THIS_MODULE);

which will again set bus to &platform_bus_type. So you might as well
drop that line.


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-07-16 17:30 +0200
  Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI  controller Paul Bolle <pebolle@tiscali.nl> - 2015-07-17 11:10 +0200

csiph-web