Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1186581

Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation

From Chen-Yu Tsai <wens@csie.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation
Date 2015-07-17 11:00 +0200
Message-ID <pN9ER-w9-3@gated-at.bofh.it> (permalink)
References <potdL-1lB-1@gated-at.bofh.it> <potdL-1lB-11@gated-at.bofh.it> <powEF-6Im-1@gated-at.bofh.it> <poRJ8-3Us-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Vishnu,

This patch did not make v4.2-rc1.

A33 support requires this patch. Otherwise the clock tree
is absent and nothing works.



On Mon, May 11, 2015 at 4:53 PM, Vishnu Patekar
<vishnupatekar0510@gmail.com> wrote:
> Hi,
>
> On Sun, May 10, 2015 at 3:47 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>> Hi,
>>
>> On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote:
>>> A33 clock control unit is similar to A23.
>>>
>>> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE
>>> to get it compiled for A33.
>>
>> That commit log doesn't make any sense.
>>
>> What you're doing isn't about whether or not that will be compiled,
>> but whether you're registering the clocks and which clocks you
>> protect.
> Actually, It's just registering the a33 clocks and reusing a23 code.
> nothing to do with compile. I'll correct it in next patch version.
>>
>>> Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com>
>>
>> Isn't it supposed to have a space in the middle of your name, just
>> like you have in your mail address?
> Yes, There should be space.
>>
>> Thanks,
>> Maxime
>>
>> --
>> Maxime Ripard, Free Electrons
>> Embedded Linux, Kernel and Android engineering
>> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation Chen-Yu Tsai <wens@csie.org> - 2015-07-17 11:00 +0200
  Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation Chen-Yu Tsai <wens@csie.org> - 2015-07-17 11:20 +0200
  Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-07-17 11:20 +0200

csiph-web