Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186504

Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding

Show all headers | View raw

2015-07-17 15:46 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> Hello Krzysztof,
>
> On 07/17/2015 08:42 AM, Krzysztof Kozlowski wrote:
>> 2015-07-17 15:29 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>:
>>> The Maxim MAX77686 PMIC is a multi-function device with regulators,
>>> clocks and a RTC. The DT bindings for the clocks are in a separate
>>> file but the bindings for the regulators are inside the mfd part.
>>>
>>> To make it consistent with the clocks portion of the binding and
>>> because is more natural to look for regulator bindings under the
>>> bindings/regulator sub-directory, split the regulator portion of
>>> the DT binding and add it as a separate file.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - Use a generic name for the max77686 node in the regulator example.
>>>
>>>  Documentation/devicetree/bindings/mfd/max77686.txt | 58 +-----------------
>>>  .../devicetree/bindings/regulator/max77686.txt     | 71 ++++++++++++++++++++++
>>>  2 files changed, 74 insertions(+), 55 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/regulator/max77686.txt
>>
>> Putting regulator bindings under regulator directory seems logical so
>> I am fine with it.
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>
> Thanks a lot for your review. For completeness, I talked with Lee Jones
> over IRC yesterday asking him his opinion on whether MFD DT binding doc
> should contain all the info or if it should be split across different
> subsystems and he prefers the later. That's why I re-spun this series.

Okay, this sounds good.

One more thing - can you update the maintainers file? The bindings
documentation is mentioned there for max77686.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] mfd: Improve DT binding docs for max77686 and max77802 Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-17 08:40 +0200
  [PATCH v2 3/4] mfd: Add DT binding for Maxim MAX77802 IC Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-17 08:40 +0200
  [PATCH v2 4/4] mfd: max77686: Split out regulator part from the DT binding Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-17 08:40 +0200
    Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the  DT binding Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-17 08:50 +0200
      Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the  DT binding Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 08:50 +0200
        Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the  DT binding Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-17 09:00 +0200
          Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the  DT binding Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 09:20 +0200
            Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the  DT binding Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-17 09:30 +0200
    Re: [PATCH v2 4/4] mfd: max77686: Split out regulator part from the  DT binding Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 08:50 +0200

csiph-web