Re: [PATCH v4] staging: rtl8192u: remove bool comparisons

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] staging: rtl8192u: remove bool comparisons
Date	2015-07-17 08:10 +0200
Message-ID	<pN70m-5nn-5@gated-at.bofh.it> (permalink)
References	<pMRHZ-8l1-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
> Remove explicit true/false comparisons to bool variables.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
<snip>
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index b852396..41cf99d 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -2043,16 +2043,10 @@ static bool GetNmodeSupportBySecCfg8192(struct net_device *dev)
>  
>  static bool GetHalfNmodeSupportByAPs819xUsb(struct net_device *dev)
>  {
> -	bool			Reval;
>  	struct r8192_priv *priv = ieee80211_priv(dev);
>  	struct ieee80211_device *ieee = priv->ieee80211;
>  
> -	if (ieee->bHalfWirelessN24GMode == true)
> -		Reval = true;
> -	else
> -		Reval =  false;
> -
> -	return Reval;
> +	return ieee->bHalfWirelessN24GMode;
I think this should have been in a separate patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4] staging: rtl8192u: remove bool comparisons Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-17 08:10 +0200
  Re: [PATCH v4] staging: rtl8192u: remove bool comparisons Luis de Bethencourt <luis@debethencourt.com> - 2015-07-17 11:10 +0200

csiph-web